Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210215181511.2840674-1-mic@digikod.net> <20210215181511.2840674-3-mic@digikod.net>
 <CAK7LNAS54Zw7d8Lp5BNs1JVktSLTFx0dNbLMA7W0U_sH2712_A@mail.gmail.com> <b3ea85ca-5c49-61ab-4769-f2e4557df3c7@digikod.net>
In-Reply-To: <b3ea85ca-5c49-61ab-4769-f2e4557df3c7@digikod.net>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Sun, 21 Feb 2021 23:45:26 +0900
Message-ID: <CAK7LNAR-WLk+y01CB7Jjx8VVw4v_qNkdiSGDNkpqvWdTu1L1jg@mail.gmail.com>
Subject: Re: [PATCH v2 2/3] kconfig: Ask user if string needs to be changed
 when dependency changed
To:     =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= <mic@digikod.net>
Cc:     Casey Schaufler <casey@schaufler-ca.com>,
        James Morris <jmorris@namei.org>,
        "Serge E . Hallyn" <serge@hallyn.com>,
        Nicolas Iooss <nicolas.iooss@m4x.org>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-security-module <linux-security-module@vger.kernel.org>,
        =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= <mic@linux.microsoft.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, Feb 21, 2021 at 8:09 PM Micka=C3=ABl Sala=C3=BCn <mic@digikod.net> =
wrote:
>
>
> On 21/02/2021 09:47, Masahiro Yamada wrote:
> > On Tue, Feb 16, 2021 at 3:14 AM Micka=C3=ABl Sala=C3=BCn <mic@digikod.n=
et> wrote:
> >>
> >> From: Micka=C3=ABl Sala=C3=BCn <mic@linux.microsoft.com>
> >>
> >> Content of string configuration may depend on related kernel
> >> configurations.  Modify oldconfig and syncconfig to inform users about
> >> possible required configuration update and give them the opportunity t=
o
> >> update it:
> >> * if dependencies of this string has changed (e.g. enabled or disabled=
),
> >> * and if the current value of this string is different than the (new)
> >>   default one.
> >>
> >> This is particularly relevant for CONFIG_LSM which contains a list of
> >> LSMs enabled at boot, but users will not have a chance to update this
> >> list with a make oldconfig.
> >
> > If CONFIG_LSM already exists in the .config,
> > oldconfig does not show a prompt.
> > This is the expected behavior.
>
> It is not the behavior wished for LSM stacking.

Because LSM is doing wrong.


> >
> > You are trying to fix your problem in a wrong way.
> > NACK.
>
> What do you suggest to ensure that users will be asked to update the
> CONFIG_LSM string if they add or remove an LSM?


Fix it in the security subsystem.


Hint:
See 050e9baa9dc9fbd9ce2b27f0056990fc9e0a08a0

--=20
Best Regards
Masahiro Yamada