Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1225862pxb; Sun, 21 Feb 2021 17:02:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJyKfLhJLTGyoo4f6J/x4PF9fVPAbJkROEWOPVOfc8X/HbV6FmbZQXc10HyQ5S6ZhmWz4y3L X-Received: by 2002:aa7:d2c4:: with SMTP id k4mr2650382edr.237.1613955735784; Sun, 21 Feb 2021 17:02:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613955735; cv=none; d=google.com; s=arc-20160816; b=BR9m6LkR7730iNPmboT76rNqRd3Z/5cVJ3SfBjw1d9RVWsVEL2PegPI9qlTg60k6ez taBMphE8dX9tixx+Bm/cijvhrfZUTmCfF0a6nM6vUTtkola7y9seQz3pM6VnUM08JQoh bfZD1OMx0PArk3qP2NAw1oD1meYs+2XEDx34Jyi9nDbzsNiglARpE0TRtU2tTIB0ddRB EYGqYiu1TUB+GiMwO+VasLWnJTsGdYsmg7yJ+8/uunV+LB7bDkxiGdsVkbDqO7MJ9vz+ qI1TXExFYV1hhEkiKbZMEgKqvED2aoZAwfaFIdXrWVNLQ2BvMJ1ygFTpniOZhFn/4vU9 aGbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6crOKhRKpotHBfZ/BTiDYj+PXhp7HEfN5SQnGsIKUrI=; b=V2vCv0k+JI82PZInu1kxeuBlkTkAlJXSvWSAaoM2TiVl3yCaKu7TibiY/fTA/69/9s /ZLYzKaNHKTk8cZCetPZfWUYliwl5/0a4y8kUiW4m7Dsp4Unil6AouUr+4tOpACjMwg8 0AKJU6IuSQFlPgG0LCnqZW82WIp0c5igHoICcl4nzubuw4uecMxeX8lP67gi7rtw1q0u sJbXgWigQFsztnzxK48Ln06t9seLMeMODHyoZod+FC8isTDWKn2/KTON1sUVrWT1OVt4 Lr1Ky8/tLc07C/Pw1xkHF2PGRoHkoznNiPiwQ1mHuvvqZc/598laFTS1p8NCIelAIK1O Q33g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=axi49CHf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k4si10652146edq.49.2021.02.21.17.01.53; Sun, 21 Feb 2021 17:02:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=axi49CHf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230155AbhBVA7g (ORCPT + 99 others); Sun, 21 Feb 2021 19:59:36 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:54344 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230135AbhBVA70 (ORCPT ); Sun, 21 Feb 2021 19:59:26 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DB8AD58E; Mon, 22 Feb 2021 01:58:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1613955522; bh=323TC+vAFgYdqYeUrXUcysK+7LkTLS6Zx5cPnpw8BHk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=axi49CHfZHV/SY0ehaNGuD0pP6Qk4JTImZFjyF6aU4EueAzBqGbi90duNUxWYwE0Z knSau8f+sJl+nLon2vDsVYqupsec/s5hi8zAeuVIGnr1/KWobJLWvZQmL/GQobvUjk ec52sihXfNzA5Fssly698HMexTIZAiWdnWMkiKkQ= Date: Mon, 22 Feb 2021 02:58:15 +0200 From: Laurent Pinchart To: Jacopo Mondi Cc: kieran.bingham+renesas@ideasonboard.com, niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/16] media: i2c: rdacm20: Embedded 'serializer' field Message-ID: References: <20210216174146.106639-1-jacopo+renesas@jmondi.org> <20210216174146.106639-3-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210216174146.106639-3-jacopo+renesas@jmondi.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, Thank you for the patch. On Tue, Feb 16, 2021 at 06:41:32PM +0100, Jacopo Mondi wrote: > There's no reason to allocate dynamically the 'serializer' field in > the driver structure. > > Embed the field and adjust all its users in the driver. > > Signed-off-by: Jacopo Mondi This requires making the max9271_device structure definition available to the rdacm20 and other drivers. Given how tightly coupled they are, I don't think that's an issue, but let's keep in mind in the future that the camera drivers should not, as a general rule, peek into the max9271_device structure directly. It may be nice to add a max9271_init() function that will initialize the client field, and move the client->addr assignment to max9271_set_address(). Maybe you've already done so in the rest of the series, I'll find out soon :-) For this patch, Reviewed-by: Laurent Pinchart > --- > drivers/media/i2c/rdacm20.c | 38 ++++++++++++++++--------------------- > 1 file changed, 16 insertions(+), 22 deletions(-) > > diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c > index f7fd5ae955d0..4d9bac87cba8 100644 > --- a/drivers/media/i2c/rdacm20.c > +++ b/drivers/media/i2c/rdacm20.c > @@ -312,7 +312,7 @@ static const struct ov10635_reg { > > struct rdacm20_device { > struct device *dev; > - struct max9271_device *serializer; > + struct max9271_device serializer; > struct i2c_client *sensor; > struct v4l2_subdev sd; > struct media_pad pad; > @@ -399,7 +399,7 @@ static int rdacm20_s_stream(struct v4l2_subdev *sd, int enable) > { > struct rdacm20_device *dev = sd_to_rdacm20(sd); > > - return max9271_set_serial_link(dev->serializer, enable); > + return max9271_set_serial_link(&dev->serializer, enable); > } > > static int rdacm20_enum_mbus_code(struct v4l2_subdev *sd, > @@ -456,11 +456,11 @@ static int rdacm20_initialize(struct rdacm20_device *dev) > int ret; > > /* Verify communication with the MAX9271: ping to wakeup. */ > - dev->serializer->client->addr = MAX9271_DEFAULT_ADDR; > - i2c_smbus_read_byte(dev->serializer->client); > + dev->serializer.client->addr = MAX9271_DEFAULT_ADDR; > + i2c_smbus_read_byte(dev->serializer.client); > > /* Serial link disabled during config as it needs a valid pixel clock. */ > - ret = max9271_set_serial_link(dev->serializer, false); > + ret = max9271_set_serial_link(&dev->serializer, false); > if (ret) > return ret; > > @@ -468,35 +468,35 @@ static int rdacm20_initialize(struct rdacm20_device *dev) > * Ensure that we have a good link configuration before attempting to > * identify the device. > */ > - max9271_configure_i2c(dev->serializer, MAX9271_I2CSLVSH_469NS_234NS | > - MAX9271_I2CSLVTO_1024US | > - MAX9271_I2CMSTBT_105KBPS); > + max9271_configure_i2c(&dev->serializer, MAX9271_I2CSLVSH_469NS_234NS | > + MAX9271_I2CSLVTO_1024US | > + MAX9271_I2CMSTBT_105KBPS); > > - max9271_configure_gmsl_link(dev->serializer); > + max9271_configure_gmsl_link(&dev->serializer); > > - ret = max9271_verify_id(dev->serializer); > + ret = max9271_verify_id(&dev->serializer); > if (ret < 0) > return ret; > > - ret = max9271_set_address(dev->serializer, dev->addrs[0]); > + ret = max9271_set_address(&dev->serializer, dev->addrs[0]); > if (ret < 0) > return ret; > - dev->serializer->client->addr = dev->addrs[0]; > + dev->serializer.client->addr = dev->addrs[0]; > > /* > * Reset the sensor by cycling the OV10635 reset signal connected to the > * MAX9271 GPIO1 and verify communication with the OV10635. > */ > - ret = max9271_enable_gpios(dev->serializer, MAX9271_GPIO1OUT); > + ret = max9271_enable_gpios(&dev->serializer, MAX9271_GPIO1OUT); > if (ret) > return ret; > > - ret = max9271_clear_gpios(dev->serializer, MAX9271_GPIO1OUT); > + ret = max9271_clear_gpios(&dev->serializer, MAX9271_GPIO1OUT); > if (ret) > return ret; > usleep_range(10000, 15000); > > - ret = max9271_set_gpios(dev->serializer, MAX9271_GPIO1OUT); > + ret = max9271_set_gpios(&dev->serializer, MAX9271_GPIO1OUT); > if (ret) > return ret; > usleep_range(10000, 15000); > @@ -560,13 +560,7 @@ static int rdacm20_probe(struct i2c_client *client) > if (!dev) > return -ENOMEM; > dev->dev = &client->dev; > - > - dev->serializer = devm_kzalloc(&client->dev, sizeof(*dev->serializer), > - GFP_KERNEL); > - if (!dev->serializer) > - return -ENOMEM; > - > - dev->serializer->client = client; > + dev->serializer.client = client; > > ret = of_property_read_u32_array(client->dev.of_node, "reg", > dev->addrs, 2); -- Regards, Laurent Pinchart