Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Quan, Evan" <Evan.Quan@amd.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>
CC:     "airlied@linux.ie" <airlied@linux.ie>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "Koenig, Christian" <Christian.Koenig@amd.com>
Subject: RE: [PATCH v2] drm/amdgpu/swsmu/navi1x: Remove unnecessary conversion
 to bool
Thread-Topic: [PATCH v2] drm/amdgpu/swsmu/navi1x: Remove unnecessary
 conversion to bool
Thread-Index: AQHXCEEAWyGwDw8ghEeNkTKiJTABAqpjgT7A
Date:   Mon, 22 Feb 2021 03:15:17 +0000
Message-ID: <DM6PR12MB2619934BA14F887DF37BF2C2E4819@DM6PR12MB2619.namprd12.prod.outlook.com>
References: <1613789706-100430-1-git-send-email-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <1613789706-100430-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Accept-Language: en-US, zh-CN
Content-Language: en-US
msip_labels: MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Enabled=true;
 MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SetDate=2021-02-22T03:14:53Z;
 MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Method=Standard;
 MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_Name=Internal Use Only -
 Unrestricted;
 MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;
 MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ActionId=68aa5021-becb-4278-9c46-8ea9e74387f8;
 MSIP_Label_76546daa-41b6-470c-bb85-f6f40f044d7f_ContentBits=1
msip_justification: I confirm the recipients are approved for sharing this
 content
authentication-results: linux.alibaba.com; dkim=none (message not signed)
 header.d=none;linux.alibaba.com; dmarc=none action=none header.from=amd.com;
x-originating-ip: [180.167.199.182]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 3fe971b5-fc0a-478f-3973-08d8d6e0144d
x-ms-traffictypediagnostic: DM5PR12MB2359:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM5PR12MB23593F9058713CAC21A18ED6E4819@DM5PR12MB2359.namprd12.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:416;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: RC7FQtkb1893ylrayO2OceG5GwdzHBt1Iag05j7w6goNUuk3hw6zBdw3S0RX44Uv/kvcrKNXgoAfftgZNv7OnFcAtR5IfqCG7pZ1DjwZiCb5e54PQrMPtEbWJLO7rAr5GbQYIfQndUcsiZ6GwmLm3kmy2iNhOEG73a7QaVRpe4FK5EpMQksV+0yH/DKP+gcCUNPAr1gKrjs4AD1mKfdMc83Pt6XuB1pcKCdXonlcptphvldG669L9Gv9+iLq8snYSmdNUxPUXj0flf7lY0s18Ze+OHANDJvkgxXZUJY5GHgHF8Bh0b80j0UfUie12VnzkkVSQRrzm9NJv8xY/9It4eCpI4/PHwxyX8kONjWmJH57q6tnYGBhPaiYx0k0dYtXf4akATMHref5DNd58G5Em+cvx+fZLKhvjxlrZdEupQ/qbtyAD1W4E2ysUE9FMs3KqzcKCB+/RYx5msn8q2k6zh8kzwxzl0fcwaWbsbg+KvnGGeaopcmTjBafgtR/OLLK/bX8CToWj1feQqWbLh2lprW0FQs1Jbkk5K6KDlFYPTIEdDCX2mLkCubmHVwS+CuVqBGzO8vALKJ39JkNXwLYA9dNG8bOe4SUnk6RrU1Y2LY=
x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2619.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(366004)(376002)(346002)(136003)(39860400002)(5660300002)(55016002)(86362001)(2906002)(66556008)(66476007)(66946007)(66446008)(64756008)(76116006)(52536014)(9686003)(316002)(83380400001)(54906003)(478600001)(45080400002)(71200400001)(53546011)(966005)(8676002)(110136005)(6636002)(4326008)(6506007)(186003)(33656002)(7696005)(8936002)(26005)(357404004);DIR:OUT;SFP:1101;
x-ms-exchange-antispam-messagedata: =?us-ascii?Q?pHYGvsWvcHDMLFKigJJ7lMBGUySuxp5Xiz8hnrNNQ9am1ISRKloMP3kyGxA2?=
 =?us-ascii?Q?zGoJ4sZ2NHABQSXpfLOGtki7uaCiNsTNAbp65TFbqrYIQKRP55hPg4l83neR?=
 =?us-ascii?Q?uAoq4gBHyAEuP0e+CrkWmjgG+vb1S5fhpB0irKHGMuTmmMJ20A+dG0D2Idpb?=
 =?us-ascii?Q?BJeetTL77ikVtA2kEVVrt/bjQVGY7rhOPg0YG4Jkw74F3g6j/caqXKKtJKlV?=
 =?us-ascii?Q?kAKmrG2AQSLUf+d1azWDPfaBJrNDkQiBlbsSgo2gbPrRsmye1wBQxOvAc7Ly?=
 =?us-ascii?Q?5AbC0kb9apOZXNgJJuRl2rayRBMz4jz+YFzcEbktqe7WsXQJyduvmvf7Vyk6?=
 =?us-ascii?Q?yOskQACo6s019X+rLfYaqYqC1RY6TwFu/3Et2MTe6IO2knYXTn3lwZ0VNN/n?=
 =?us-ascii?Q?JUuQIDxSTb/KtlzEqfiOMqBDhPqaOIeZ4II8Q7KQEUg8MHs3qfOPEU84LNh9?=
 =?us-ascii?Q?AI/BUF2G/Xcunp3sYGi/DGRy9WJlI3/OvzzSspQir9aIXkWK5bLy/Mm71iLd?=
 =?us-ascii?Q?DWseyc5xI5mlLA0eaxOkZgqlrTgDFyNMGGqwlGtX6HDwZpzFZ22tX02gfsFu?=
 =?us-ascii?Q?o5hpqEZhprkILpKojUEuuObbViRT9ZR4X+tjjPt0hLlHAJJLAUGkENo4xS6P?=
 =?us-ascii?Q?eYcz3KePBppwB/jROh4DI0LvJteq/SoSbT+alMO1ZfUgwjmmN66orZV6digt?=
 =?us-ascii?Q?ICQD+uEqtDhumqcEQHfa3vmYRNGfOoqQUZFnRT6eY+57zXuiaFm8ClkBfc7p?=
 =?us-ascii?Q?aEzOBDd+1kWAuMvR1qKE444XpxvI6/ucTuqbGH9KhQC2aQVkPGUIhSJM2vL/?=
 =?us-ascii?Q?FWaEuxSw8ZwkXf9ooUqMrBm9cok9V8tKMIXyjtF3usTIHTE/HZi9T9vfgjgl?=
 =?us-ascii?Q?hSazn1+73e2sRk/fo+7n+IKjIw08w/+t6Mp9JJm0edN2Ft8GEJTueBwdZ0VL?=
 =?us-ascii?Q?AsAmZX3s/8gl7H6fI6G8VwvtNr5lGjOYhywLSSLbZkx7fh0CH9tOZK05xC/C?=
 =?us-ascii?Q?E4A9KNBEZ3dcL+Gs42juOrwDUJaQwqje0+KelOA5q47fUOCCLtYFUmS3ZNeg?=
 =?us-ascii?Q?VNTpF3+R+neQPH77httPQ4NcU8ObXpgNd9yJW3zsupqIdGYtEUAY462Oz5zE?=
 =?us-ascii?Q?q8BimbkTzOT0qoLorM+8ESt2r3jB9uzhIGXW2uzw3uVUgL+PPdv8znjJqguj?=
 =?us-ascii?Q?MWp3QRHfAAFuqoj6z8KjuoG8XonLFYgrf3mXBtkhh2pOigvDrMI7QzKRZyL9?=
 =?us-ascii?Q?ES60n/nVDUYQe47aU4aDpz+gRns5f/3C3XHepA491rWP1dB7hzdQ2rsz4HSS?=
 =?us-ascii?Q?fUYk14dbu0GcjFHmcbNofkTG?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2619.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fe971b5-fc0a-478f-3973-08d8d6e0144d
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2021 03:15:17.2769
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6FTvl/FJ8H+uIoVJyMdYoPihubNzlQFudDfSi27BZk+4ICrkuj6a8Sg1cPQrfG1Q
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2359
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[AMD Official Use Only - Internal Distribution Only]

Reviewed-by: Evan Quan <evan.quan@amd.com>

-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Jiapeng =
Chong
Sent: Saturday, February 20, 2021 10:55 AM
To: Deucher, Alexander <Alexander.Deucher@amd.com>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>; airlied@linux.ie; linu=
x-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; amd-gfx@lists.fr=
eedesktop.org; daniel@ffwll.ch; Koenig, Christian <Christian.Koenig@amd.com=
>
Subject: [PATCH v2] drm/amdgpu/swsmu/navi1x: Remove unnecessary conversion =
to bool

Fix the following coccicheck warnings:

./drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c:900:47-52: WARNING:
conversion to bool not needed here.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/drivers/gpu/=
drm/amd/pm/swsmu/smu11/navi10_ppt.c
index cd7efa9..58028a7 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
@@ -897,7 +897,7 @@ static bool navi10_is_support_fine_grained_dpm(struct s=
mu_context *smu, enum smu
 	dpm_desc =3D &pptable->DpmDescriptor[clk_index];
=20
 	/* 0 - Fine grained DPM, 1 - Discrete DPM */
-	return dpm_desc->SnapToDiscrete =3D=3D 0 ? true : false;
+	return dpm_desc->SnapToDiscrete =3D=3D 0;
 }
=20
 static inline bool navi10_od_feature_is_supported(struct smu_11_0_overdriv=
e_table *od_table, enum SMU_11_0_ODFEATURE_CAP cap)
--=20
1.8.3.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flists.f=
reedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&amp;data=3D04%7C01%7Cevan.qua=
n%40amd.com%7C443a5df938954827326108d8d6582201%7C3dd8961fe4884e608e11a82d99=
4e183d%7C0%7C0%7C637495021310885387%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA=
wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3D6ETa=
diVbRBgbXfEbkXbxTX%2F1Ozg1wp3Nr9lHGF3SKHk%3D&amp;reserved=3D0