Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1283462pxb; Sun, 21 Feb 2021 19:32:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJyePE6SjSF052FQkc2W6vrrU340fTBhDRnSqXJhnAXqUX4xa14DjsS0IP7aP2PM/btTuoIB X-Received: by 2002:a17:906:28d0:: with SMTP id p16mr18309472ejd.124.1613964767887; Sun, 21 Feb 2021 19:32:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613964767; cv=none; d=google.com; s=arc-20160816; b=ZINpJJYvzTWaKqC4LrqsW4LbPT/yfxHEAds7ZStQ8zDPSTJDn4Yk4+Tjz1V44RiT/I ECO3Y6N8JDlKpj8ocUap8E02SbaKfpcUmEwmnA9Gjf2fpEbHpPDBzl4s5ER3RwTL2r3m 8hT4t5kWAGOKsEHxT9qih+JfBkb5iJKTRx/p2PTsQW3vrSv+33Z1b2dNx2Mu8yJhVzdV BjEFwJ5UgpUhDPh5AQw6KPue+CB16nK6jZJcD2thIo+i23W41J617vcCLTk2kp+O7pRp fPMIglm3IDhvobIekvIi75A2vDHwseUH/c66mfHbodHBd7lzUy4EAukdVIM5RLAabrQj RtTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=2/j5Lqy5dhvDPN7B6GDS9vPRNJDpnM+aTBfnWbXMC7w=; b=phni0e0OvyYbAwelt7BlzxpD+uv7q/Ze1oWfW0M38vOBdei84ikeJRyH8lOkG2IdK0 cykVPrzUvfzTNQxzB4CUrgV9gbtWhQuj/s39RyeSFInHvE/w07yv5vZsWBq6H5dhLz3R CcwP+gtAlp8VLe9+8SHh49IQ0/nhUy8KSMiLlaNB+hhlHZcELcvc8PiLk0SLYvWBCm+2 2+mxeKIiEi1OSXWhv3c47s0HccvVHCNDYbT4n7/fE9Bl0u27j+1w0X3jFcsgOkABwjdp vq/j6Fc2T6wwqNUl1v/AOUuT4NHIU5bEjJTYq70jEhNTzgJDCNG0yBylfgR6h0gQCedy t71A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=OtRJW4wq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g7si10874660edh.31.2021.02.21.19.32.25; Sun, 21 Feb 2021 19:32:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=merlin.20170209 header.b=OtRJW4wq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230049AbhBVD3q (ORCPT + 99 others); Sun, 21 Feb 2021 22:29:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229863AbhBVD3p (ORCPT ); Sun, 21 Feb 2021 22:29:45 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABC0CC061574; Sun, 21 Feb 2021 19:29:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:MIME-Version: Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=2/j5Lqy5dhvDPN7B6GDS9vPRNJDpnM+aTBfnWbXMC7w=; b=OtRJW4wqXmNWb5xMEq9F+WqDJf aPhAT9Xw3GzbfmQkSSruEZcR20orlmcwzomgY+Z/9sZGzmBOf/612nLV6aYXzAdJBN4N8PsovftZm IC0fXQbawnBjb6XS6CTsnthabiNdzyrH/Gz+GjHun2cyEShhnS5us5HO5+eCo759nN85IKjdGZOms Q3olCqW6gTnKPSfGFxeRrXA41UReb4818SsELVc8ZM3OpuaeWPzIkwyvXfbKoaC29NIZB3xR989st p7GCx1FWfJ1tmKDU+PCvgUc7JVqu/3y1EbBjDqiCEPwHvCWeR2D5nig3WPNEar2rTcDPLjj37CWqD KEWjUZzA==; Received: from [2601:1c0:6280:3f0::d05b] (helo=merlin.infradead.org) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1lE1u7-0003dI-HH; Mon, 22 Feb 2021 03:29:00 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , kernel test robot , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , Sam Ravnborg , Daniel Vetter , David Airlie , Jani Nikula Subject: [PATCH] fbdev: atyfb: add stubs for aty_{ld,st}_lcd() Date: Sun, 21 Feb 2021 19:28:53 -0800 Message-Id: <20210222032853.21483-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix build errors when these functions are not defined. ../drivers/video/fbdev/aty/atyfb_base.c: In function 'aty_power_mgmt': ../drivers/video/fbdev/aty/atyfb_base.c:2002:7: error: implicit declaration of function 'aty_ld_lcd'; did you mean 'aty_ld_8'? [-Werror=implicit-function-declaration] 2002 | pm = aty_ld_lcd(POWER_MANAGEMENT, par); ../drivers/video/fbdev/aty/atyfb_base.c:2004:2: error: implicit declaration of function 'aty_st_lcd'; did you mean 'aty_st_8'? [-Werror=implicit-function-declaration] 2004 | aty_st_lcd(POWER_MANAGEMENT, pm, par); Signed-off-by: Randy Dunlap Reported-by: kernel test robot Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: Bartlomiej Zolnierkiewicz Cc: Sam Ravnborg Cc: Daniel Vetter Cc: David Airlie Cc: Jani Nikula --- drivers/video/fbdev/aty/atyfb_base.c | 9 +++++++++ 1 file changed, 9 insertions(+) --- linux-next-20210219.orig/drivers/video/fbdev/aty/atyfb_base.c +++ linux-next-20210219/drivers/video/fbdev/aty/atyfb_base.c @@ -175,6 +175,15 @@ u32 aty_ld_lcd(int index, const struct a return aty_ld_le32(LCD_DATA, par); } } +#else /* defined(CONFIG_PMAC_BACKLIGHT) || defined(CONFIG_FB_ATY_BACKLIGHT) \ + defined(CONFIG_FB_ATY_GENERIC_LCD) */ +void aty_st_lcd(int index, u32 val, const struct atyfb_par *par) +{ } + +u32 aty_ld_lcd(int index, const struct atyfb_par *par) +{ + return 0; +} #endif /* defined(CONFIG_PMAC_BACKLIGHT) || defined (CONFIG_FB_ATY_GENERIC_LCD) */ #ifdef CONFIG_FB_ATY_GENERIC_LCD