Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Li, Meng" <Meng.Li@windriver.com>
To:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "maz@kernel.org" <maz@kernel.org>,
        "lee.jones@linaro.org" <lee.jones@linaro.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "Hao, Kexin" <Kexin.Hao@windriver.com>
Subject: RE: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for
 regmap_config"
Thread-Topic: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for
 regmap_config"
Thread-Index: AQHW6uDlVrPMRNLctkuz9Bvou6uZzqpjw5uQ
Date:   Mon, 22 Feb 2021 03:45:12 +0000
Message-ID: <CO1PR11MB48497CB7B11EDA65A3941FDCF1819@CO1PR11MB4849.namprd11.prod.outlook.com>
References: <20210115015050.26657-1-meng.li@windriver.com>
In-Reply-To: <20210115015050.26657-1-meng.li@windriver.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a37080c-58cb-474f-7227-08d8d6e4428a
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2021 03:45:12.9375
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 03hep9ExO62+UkbOrJnBBr7SFfd19ajD3t4xJZoPFHP1/dOQ2dYvOg4NAmA2dnh59nzpICSvIRqui52AiV1fGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2317
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Marc&Lee,

Is there any comment on this patch?
Could you please help to review this patch so that I can improve it if it s=
till has weakness?

Thanks,
Limeng

> -----Original Message-----
> From: Li, Meng <Meng.Li@windriver.com>
> Sent: Friday, January 15, 2021 9:51 AM
> To: linux-kernel@vger.kernel.org
> Cc: maz@kernel.org; lee.jones@linaro.org; arnd@arndb.de; Hao, Kexin
> <Kexin.Hao@windriver.com>; Li, Meng <Meng.Li@windriver.com>
> Subject: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for
> regmap_config"
>=20
> From: Limeng <Meng.Li@windriver.com>
>=20
> This reverts commit 529a1101212a785c5df92c314b0e718287150c3b.
>=20
> The reverted patch moves the memory free to error path, but introduce a
> memory leak. There is another commit 94cc89eb8fa5("regmap: debugfs:
> Fix handling of name string for debugfs init delays") fixing this debugfs=
 init
> issue from root cause. With this fixing, the name field in struct
> regmap_debugfs_node is removed. When initialize debugfs for syscon driver=
,
> the name field of struct regmap_config is not used anymore. So, revert th=
is
> patch directly to avoid memory leak.
>=20
> v2:
> Notify the author of the reverted commit by adding Cc:
>=20
> Fixes: 529a1101212a("mfd: syscon: Don't free allocated name for
> regmap_config")
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: stable@vger.kernel.org
> Signed-off-by: Meng Li <Meng.Li@windriver.com>
> ---
>  drivers/mfd/syscon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c index
> ca465794ea9c..df5cebb372a5 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -108,6 +108,7 @@ static struct syscon *of_syscon_register(struct
> device_node *np, bool check_clk)
>  	syscon_config.max_register =3D resource_size(&res) - reg_io_width;
>=20
>  	regmap =3D regmap_init_mmio(NULL, base, &syscon_config);
> +	kfree(syscon_config.name);
>  	if (IS_ERR(regmap)) {
>  		pr_err("regmap init failed\n");
>  		ret =3D PTR_ERR(regmap);
> @@ -144,7 +145,6 @@ static struct syscon *of_syscon_register(struct
> device_node *np, bool check_clk)
>  	regmap_exit(regmap);
>  err_regmap:
>  	iounmap(base);
> -	kfree(syscon_config.name);
>  err_map:
>  	kfree(syscon);
>  	return ERR_PTR(ret);
> --
> 2.17.1