Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1341985pxb; Sun, 21 Feb 2021 22:07:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7ylevOe01MAFQHRzw8Mc4yM/2IG4vV+5Rm68kBIrNBSitVonXacsd0B8yr1tZ4CSa/UHj X-Received: by 2002:a17:906:d117:: with SMTP id b23mr10363344ejz.151.1613974024583; Sun, 21 Feb 2021 22:07:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613974024; cv=none; d=google.com; s=arc-20160816; b=k18x8MwHAQMEiRH1ydCQ6zcz/+r918TLYJGRB+VAQ+Ew4aDlEWG/c1CEixTe25+x0/ mI1znmbUoh9uuvcfAm2eSBAMEUP53As9fdTIdjspqpYdmhe2LZiSb+AS7T5uP5BMvbm8 8A17zyTqi7WyIRmUZP0jo7t1bYB+VpO6xPop8mxYeAGFd/NXi6mT9zjyPl6zmwzyJBPn MJF0Pf4a+1jQ+bxhWXb4PjS225m3IQPp7AfegIymMvhdvUdFsov/HrjfXtJwhJzHZmAm afRfNOOZ2jFmHisIjGsTgfwkIHY/pbW/Tz2ZxD3NXaiIFQ4Zh+T84ZaxcuV7UjUZy/pO lRMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=oK9kSBYENNf/NA4eVq0FsQW/vSE74+7stespCmHxHhY=; b=JjYWsDdXyc2oqICJeNr0FMvcbQ8Q5aAyJZjw76je13hlarBA3Qa6ZVBb3u8zxfCnlP jpu2lhTWWaWyxqjcEhKPXRS++jE7269U4rMTzTCFzcIAAJ1KwzQcwYuAKZQkqcHyfnje 1Jn6GrIBDSwVBInzD12q5wvROUxPUoPzx20B3QrnRkg8mSWhUAwTkSLdbg+g7KdQyzC2 qmGwWUhxCXEM5P+/qcnfHZEKT9xwgqt7yCFb7w4IO0uoQwiqaz49CJyNdP/xGqm8RKHf aSqMHiGABpWTj+NcdPZjx4Pel4A3BT4dbulnkm6q05/8Fn7o/LQwlBoFyRjskxtAe4sQ pM9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=sv+o7vKn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cq1si8456589edb.162.2021.02.21.22.06.42; Sun, 21 Feb 2021 22:07:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=sv+o7vKn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229863AbhBVGF0 (ORCPT + 99 others); Mon, 22 Feb 2021 01:05:26 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:42464 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbhBVGFX (ORCPT ); Mon, 22 Feb 2021 01:05:23 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11M64axT046350; Mon, 22 Feb 2021 06:04:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=oK9kSBYENNf/NA4eVq0FsQW/vSE74+7stespCmHxHhY=; b=sv+o7vKnxe0GoUUjhrL+HXfXU0LUdj/73D2GfkOmB+zbu9Qd1S+SUenoU/potNLD+t6G QxUp35a86CuEoC7Z+gm1Ah31+c8remBGF9CBfZk4Q6sqHqgZNFdYc586XCPwepP2SGEU qQj94SGMxYwWmzQzqTnDYEETVXHeASM2BvhXLQ8YxESvmEpWzpqHKOYhj7rjTTGfZIj9 n0KEkYItP03XvP87UlV1KKRWliuaH8rlpT0FO7SoFXG5OzZdgivcrnVyY5AnaceyBA6V rwvjracap9yUwVvrTC9/e8yAswIAEOSSsrtuk9/mcatrkatiIgJhAWHg21XGfjToxdC2 rg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2130.oracle.com with ESMTP id 36tqxbah9s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Feb 2021 06:04:35 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11M5uNUH040087; Mon, 22 Feb 2021 06:04:30 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 36ucbvnmhw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Feb 2021 06:04:30 +0000 Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 11M64SWi003837; Mon, 22 Feb 2021 06:04:28 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 22 Feb 2021 06:04:28 +0000 Date: Mon, 22 Feb 2021 09:04:17 +0300 From: Dan Carpenter To: Christophe JAILLET Cc: balbi@kernel.org, gregkh@linuxfoundation.org, krzk@kernel.org, nathan@kernel.org, ndesaulniers@google.com, arnd@arndb.de, gustavoars@kernel.org, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 2/2] usb: gadget: s3c: Fix the error handling path in 's3c2410_udc_probe()' Message-ID: <20210222060417.GJ2087@kadam> References: <20210221074133.938017-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210221074133.938017-1-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9902 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=819 adultscore=0 phishscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102220054 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9902 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 impostorscore=0 phishscore=0 mlxlogscore=749 malwarescore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 priorityscore=1501 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102220055 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 21, 2021 at 08:41:33AM +0100, Christophe JAILLET wrote: > Some 'clk_prepare_enable()' and 'clk_get()' must be undone in the error > handling path of the probe function, as already done in the remove > function. > > Fixes: 1c6d47aa4f4b ("USB Gadget driver for Samsung s3c2410 ARM SoC") > Signed-off-by: Christophe JAILLET > --- > checkpatch reports: > WARNING: Unknown commit id '1c6d47aa4f4b', maybe rebased or not pulled? > According to https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/usb/gadget/s3c2410_udc.c?id=3fc154b6b8134b98bb94d60cad9a46ec1ffbe372 > the commit ID looks correct to me. Maybe something should be tweaked somewhere > before applying, but I don't know what! Same thing. The hash is 3fc154b6b8134b98bb94d60cad9a46ec1ffbe372 regards, dan carpenter