Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1344811pxb; Sun, 21 Feb 2021 22:13:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJzvGRbe7DlvWu8H7FEpSP4LkWzCCupS6TlGmJjmXXO6Sgb6gSFBPFFUNhAI6i4n4HjGZIm6 X-Received: by 2002:a17:906:1241:: with SMTP id u1mr19661969eja.196.1613974419916; Sun, 21 Feb 2021 22:13:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613974419; cv=none; d=google.com; s=arc-20160816; b=fyUgDlVDT3V49JO4KOOtO4xnsEIwVrcg96nH+hgaVgGmuxsu05TlNBFFZQShgqm2Vt 5aHGyOA6iERgBPnMMOCxu+PdgAYxsPGPMY7wBhRwC5Jfy3cQtXmU9UzaNkamplutElLK kuiCee26l25RG9Y5MBSeJ8UXh8+VSxu97h+ZvmsWSdyCFlsqmKuTNA78wMaultPNNB9i vgfjn0xpCgJQ0aDs+mm+2GmHnTHOmlmsqEAdin+JhfBBAwCnBcZFgXMGGcK9KSYrDC1q p8Mr3V/6w0HUqoUXJcGV1IM2aAhLjmQMieZ2VDwaXbF8S56PjtlqeZi9rL8gwy6ZQS+1 sj8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=dskati5UwSnFp6iLsT0EvB/c+zNbAHk1U1z3oAfBeKs=; b=K8Pyee5aDgsP32kjlaGKMPIwQoI2KjStSSI+vffp+fA3xxDF2epF0uizIqz5HAFidC aOA/NIrN9aX2ma125LVjSstGka8XCCzNEgc7T+IGBH5xh4fuoBU7ZnRc7iQaldQcmZFa OylSDW4Om7yXZbAQJ+IsW0lBr1vB6e0ytJ28iIz70/YNgfSrEyb2ssz0M4dd3WG1KKzM tiA1ozGPW+CDlDbrBOACyOKpZIqU0vC+tEskYO4+C6MNddomJ4yAYBuzEAordNH4oG7f 7CwKrdRSMe+8sKm+KiD4oR6dLBji/pjT5chJZL6vOxx9FSAFMGBxm+aO1h8gO95F/YlE YtVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id yh27si10855947ejb.266.2021.02.21.22.13.17; Sun, 21 Feb 2021 22:13:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229966AbhBVGLb (ORCPT + 99 others); Mon, 22 Feb 2021 01:11:31 -0500 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:42719 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbhBVGLa (ORCPT ); Mon, 22 Feb 2021 01:11:30 -0500 Received: from spf.mail.chinamobile.com (unknown[172.16.121.9]) by rmmx-syy-dmz-app01-12001 (RichMail) with SMTP id 2ee160334ad88ef-da1cd; Mon, 22 Feb 2021 14:10:32 +0800 (CST) X-RM-TRANSID: 2ee160334ad88ef-da1cd X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[223.112.105.130]) by rmsmtp-syy-appsvr05-12005 (RichMail) with SMTP id 2ee560334ad53d8-bb2a8; Mon, 22 Feb 2021 14:10:32 +0800 (CST) X-RM-TRANSID: 2ee560334ad53d8-bb2a8 From: Tang Bin To: glaroque@baylibre.com, rui.zhang@intel.com, daniel.lezcano@linaro.org, amitk@kernel.org Cc: linux-pm@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Tang Bin Subject: [PATCH] thermal: amlogic: Omit superfluous error message in amlogic_thermal_probe() Date: Mon, 22 Feb 2021 14:11:05 +0800 Message-Id: <20210222061105.6008-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function devm_platform_ioremap_resource has already contains error message, so remove the redundant dev_err here. Signed-off-by: Tang Bin --- drivers/thermal/amlogic_thermal.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/thermal/amlogic_thermal.c b/drivers/thermal/amlogic_thermal.c index ccb1fe18e..bba9f3b14 100644 --- a/drivers/thermal/amlogic_thermal.c +++ b/drivers/thermal/amlogic_thermal.c @@ -253,10 +253,8 @@ static int amlogic_thermal_probe(struct platform_device *pdev) platform_set_drvdata(pdev, pdata); base = devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(base)) { - dev_err(dev, "failed to get io address\n"); + if (IS_ERR(base)) return PTR_ERR(base); - } pdata->regmap = devm_regmap_init_mmio(dev, base, pdata->data->regmap_config); -- 2.20.1.windows.1