Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: RE: [PATCH v21 2/4] scsi: ufs: L2P map management for HPB read
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Avri Altman <Avri.Altman@wdc.com>,
        Daejun Park <daejun7.park@samsung.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "huobean@gmail.com" <huobean@gmail.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        JinHwan Park <jh.i.park@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>,
        SEUNGUK SHIN <seunguk.shin@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>
In-Reply-To: <DM6PR04MB6575F5244F17B022E6E78DC7FC829@DM6PR04MB6575.namprd04.prod.outlook.com>
Message-ID: <20210222081658epcms2p4dcc6bfa0da7b6222cc4262a36374d3ad@epcms2p4>
Date:   Mon, 22 Feb 2021 17:16:58 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <DM6PR04MB6575F5244F17B022E6E78DC7FC829@DM6PR04MB6575.namprd04.prod.outlook.com>
        <20210218090627epcms2p639c216ccebed773120121b1d53641d94@epcms2p6>
        <20210218090747epcms2p8812c04126d57b789f471126055577ae8@epcms2p8>
        <CGME20210218090627epcms2p639c216ccebed773120121b1d53641d94@epcms2p4>
Precedence: bulk

> +static bool ufshpb_is_hpb_rsp_valid(struct ufs_hba *hba,
> > +                                        struct ufshcd_lrb *lrbp,
> > +                                        struct utp_hpb_rsp *rsp_field)
> > +{
> > +       if (be16_to_cpu(rsp_field->sense_data_len) != DEV_SENSE_SEG_LEN ||
> > +           rsp_field->desc_type != DEV_DES_TYPE ||
> > +           rsp_field->additional_len != DEV_ADDITIONAL_LEN ||
> > +           rsp_field->active_rgn_cnt > MAX_ACTIVE_NUM ||
> > +           rsp_field->inactive_rgn_cnt > MAX_INACTIVE_NUM ||
> > +           (rsp_field->hpb_op == HPB_RSP_REQ_REGION_UPDATE &&
> > +            !rsp_field->active_rgn_cnt && !rsp_field->inactive_rgn_cnt))
> > +               return false;
> > +
> > +       /* we cannot access HPB from other LU */
> > +       if (lrbp->lun != rsp_field->lun)
> > +               return false;
> Why not?
> Clearly this against the spec which allows to attach hpb sense crossed luns
>  
> > +
> > +       if (!ufshpb_is_general_lun(lrbp->lun)) {
> > +               dev_warn(hba->dev, "ufshpb: lun(%d) not supported\n",
> > +                        lrbp->lun);
> > +               return false;
> > +       }
> > +
> > +       return true;
> > +}
>  
>  
>  
>  
> > +void ufshpb_rsp_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
> > +{
> > +       struct ufshpb_lu *hpb = ufshpb_get_hpb_data(lrbp->cmd->device);
> > +       struct utp_hpb_rsp *rsp_field;
> > +       int data_seg_len;
> > +
> > +       if (!hpb)
> > +               return;
> Ditto

I fixed the code to support the crossed-hint.

Thanks,
Daejun