Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: RE: [PATCH v21 4/4] scsi: ufs: Add HPB 2.0 support
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Avri Altman <Avri.Altman@wdc.com>,
        Daejun Park <daejun7.park@samsung.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "huobean@gmail.com" <huobean@gmail.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        JinHwan Park <jh.i.park@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>,
        SEUNGUK SHIN <seunguk.shin@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>
In-Reply-To: <DM6PR04MB6575B0CAAAEFACBC719257F5FC839@DM6PR04MB6575.namprd04.prod.outlook.com>
Message-ID: <20210222082155epcms2p4bf924773e8497cf75d72ab9eef1a0d1c@epcms2p4>
Date:   Mon, 22 Feb 2021 17:21:55 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <DM6PR04MB6575B0CAAAEFACBC719257F5FC839@DM6PR04MB6575.namprd04.prod.outlook.com>
        <20210218090627epcms2p639c216ccebed773120121b1d53641d94@epcms2p6>
        <20210218090853epcms2p8ccac0b5611dec22afd04ecc06e74498e@epcms2p8>
        <CGME20210218090627epcms2p639c216ccebed773120121b1d53641d94@epcms2p4>
Precedence: bulk

> >         kmem_cache_destroy(hpb->map_req_cache);
> > @@ -1670,7 +2109,7 @@ void ufshpb_init_hpb_lu(struct ufs_hba *hba, struct
> > scsi_device *sdev)
> >         if (ret)
> >                 goto out;
> > 
> > -       hpb = ufshpb_alloc_hpb_lu(hba, lun, &hba->ufshpb_dev,
> > +       hpb = ufshpb_alloc_hpb_lu(hba, sdev, &hba->ufshpb_dev,
> >                                   &hpb_lu_info);
> >         if (!hpb)
> >                 goto out;
> In HPB2.0 device control mode, the host is expected to send HPB-WRITE-BUFFER 0x3
> To informs that all HPB Regions are inactive (expect for pinned regions).
> Maybe a good place to do so is here, or in ufshpb_hpb_lu_prepared after you kicked the map work for pinned regions.

Done

> Either way, If you decide to do so, I would appreciate if you could align to the framework I proposed in
> (scsi: ufshpb: Region inactivation in host mode).
> This way you would have a wrapper unmap_all that would call ufshpb_issue_umap_req with buffer id 0x3,
> And I would have a wrapper unmap_single that would call it with buffer id 0x1.

I will do this way on the next patch.

Thanks,
Daejun