Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1407413pxb; Mon, 22 Feb 2021 00:36:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJx+j92gaVGk5B+WbIrV2YyejmHhCzqePFcO7OQ/4ML6G6CyunvF+QG9suSoWFPN+2J8Ksp6 X-Received: by 2002:a05:6402:1750:: with SMTP id v16mr22286010edx.54.1613982990121; Mon, 22 Feb 2021 00:36:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613982990; cv=none; d=google.com; s=arc-20160816; b=ZqcbpzeCCJkpAY+PJ8eFhy5Y5VzJaIFp8R3sF0wWQdt4oo2rj2nygegqP2wXMjQmIS 08Zmh5Q7WHmW2ADiWSq/mP+1M7hSWzoENn8HRl5LVabD+R5UByI9tHzIBoLPU8LaXnxH 53cZavHdph5go43fEII4TmD7HXMt+U34+knlU58QFbWntWoxffqTgrk8fVDa3HBt7Ej0 tPAOO4UTVXWRXPxq5AhGl4t47nmjWNs1xqd3rQzdtjpmIW4Eygud4mlTamJARJrkzDu7 5Vch3vhZ/rnTP2lLuvmCopPKIp7WrrfQ9J6yue1UPa2OPFlPngwUihCaaiRvQCweAq4+ 1ydw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=NqP2Z9l7m9SxBEtOfLpwsAQsomHIo0Z2IbdgCkb+FPI=; b=peo7iGdbcda20XUCBRtU5D64R/FjY/M54jz5CVaq8fIryfCG6RxjyyCu+k6btRr1/T DVN5pPBbLi0Wad6OyGuhAM6A5jYMzlgPEL1qhWbbhUu2/cw5ycrprayo0ibu+nkPJk2V jZcwuaGEqQkQur5sv+h/C0WrQK2ZmIem/rX4fMqu9XRT8yyXV4H5ciQ4vh1bftN9nqlV lEs6NUPaT2Fuab+nksOAmxV/d3w6KBLcON4IPLR+gqHBJn1Wr7Qw7ruLAXM4vOvDT9En KNZQ91m2L8LcPF0nQHQtCoA7NGIAj6/3j34trCKOYkXWhPKmRV2PBi/TAk/QyQws+5AQ UVaQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p12si10605703ejc.15.2021.02.22.00.36.07; Mon, 22 Feb 2021 00:36:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229990AbhBVId2 (ORCPT + 99 others); Mon, 22 Feb 2021 03:33:28 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2591 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229852AbhBVId1 (ORCPT ); Mon, 22 Feb 2021 03:33:27 -0500 Received: from fraeml704-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4DkZxm2bjyz67bmb; Mon, 22 Feb 2021 16:25:32 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml704-chm.china.huawei.com (10.206.15.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2106.2; Mon, 22 Feb 2021 09:32:43 +0100 Received: from [10.210.165.112] (10.210.165.112) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 22 Feb 2021 08:32:43 +0000 Subject: Re: [PATCH] scsi: iscsi: Switch to using the new API kobj_to_dev() To: Yang Li , CC: , , , , , References: <1613978804-4846-1-git-send-email-yang.lee@linux.alibaba.com> From: John Garry Message-ID: <4fa2baa0-8727-9e72-eb42-db773401b8a1@huawei.com> Date: Mon, 22 Feb 2021 08:30:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <1613978804-4846-1-git-send-email-yang.lee@linux.alibaba.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.210.165.112] X-ClientProxiedBy: lhreml748-chm.china.huawei.com (10.201.108.198) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/02/2021 07:26, Yang Li wrote: > fixed the following coccicheck: > ./drivers/scsi/scsi_transport_iscsi.c:436:60-61: WARNING opportunity for > kobj_to_dev() > ./drivers/scsi/scsi_transport_iscsi.c:1128:60-61: WARNING opportunity > for kobj_to_dev() > ./drivers/scsi/scsi_transport_iscsi.c:4043:61-62: WARNING opportunity > for kobj_to_dev() > ./drivers/scsi/scsi_transport_iscsi.c:4312:61-62: WARNING opportunity > for kobj_to_dev() > ./drivers/scsi/scsi_transport_iscsi.c:4456:61-62: WARNING opportunity > for kobj_to_dev() that API is not new, so please in future stop writing that. And 'new' is a time-dependent term, and not appropriate to use anyway. Thanks, John > > Reported-by: Abaci Robot > Signed-off-by: Yang Li