Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1419767pxb; Mon, 22 Feb 2021 01:06:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJyDc+fdQogw3qelG5j6301KHanayzR+UT7lrmlo/Qh21m7p+BU/P+3WbOSf3lf9QPnsxMpt X-Received: by 2002:a17:906:ca04:: with SMTP id jt4mr20562251ejb.548.1613984762350; Mon, 22 Feb 2021 01:06:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613984762; cv=none; d=google.com; s=arc-20160816; b=xG8x6MCOoK4gLWlzbsRQk63FybXD8H5api9BSt019k3ZoV0t2G+jCksNm+9/ozR1BO +K72qMYFXXAK+pbLLqSU9zt4y3QQQtHGaUPVU6f7D1AyLPkuPZjUY8YQipLvDA9Du385 My3W6nHiIEOvNin/8Agox+px7Fy9a2so9jLq6wqVk2exuKvtf9/YbBFbdbUFuKmDKKQk 6l+5JCDHMkq62aSrL5y4+80s1zEr8aRWOYSlGsPNJoUC6eM/vfMRI5djQRWUR1+oCMFD hlc9sFHmYjrcsTwonbwR20yC/66El0vanN0ro4eJLEwp2bCd5D4MgrlsgcmKdioG/jzW CX5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=5l1jGT81ZPSNKkCIpl+tBOpeRem4xxz7unvR27nhq34=; b=WCj/EuYI/DCPcULryTRi+0sjNuWqxE+1SnlhiqYuOB221wQ98plJONWnSH5vMLcH66 /AdVK6O2NlT+roaY3Hma966wLJrM8kuVtCERTFgeGcmt39SucZDURUBck0JoW+IoEzB5 21w8muVhoH0e/VvyC0S4nO9UY0cTej3s/YPObVvOFTI0jeoEXauzu6c3R2l1yIzjIsMa aFLCKSXWzAMFdXVN1p9JI9LB31/8vb09bP7lpn4EzMFHZVxuoGxb61DazVs7pLOWyXc8 HnLMwuipiXVo1XIm4OYPL9f8pHyssKpchHe4eZ6+3PjTRaqNVwwKIDgcgJlLlmenL8Jd jkJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h5si13311538edd.237.2021.02.22.01.05.39; Mon, 22 Feb 2021 01:06:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230018AbhBVJDU (ORCPT + 99 others); Mon, 22 Feb 2021 04:03:20 -0500 Received: from mx2.suse.de ([195.135.220.15]:56210 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230100AbhBVJCw (ORCPT ); Mon, 22 Feb 2021 04:02:52 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E218DAF99; Mon, 22 Feb 2021 09:02:01 +0000 (UTC) Subject: Re: [PATCH v3 02/11] drm: Rename plane atomic_check state names To: Maxime Ripard Cc: Maarten Lankhorst , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, Laurent Pinchart , Harry Wentland , Leo Li , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , Daniel Vetter , "James (Qian) Wang" , Liviu Dudau , Mihail Atanassov , Brian Starkey , Russell King , Dave Airlie , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Stefan Agner , Alison Wang , Xinliang Liu , Tian Tao , John Stultz , Xinwei Kong , Chen Feng , Laurentiu Palcu , Lucas Stach , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Paul Cercueil , Anitha Chrisanthus , Edmund Dea , Chun-Kuang Hu , Matthias Brugger , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Clark , Sean Paul , Ben Skeggs , Tomi Valkeinen , Gerd Hoffmann , Kieran Bingham , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Benjamin Gaignard , Vincent Abriou , Yannick Fertre , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Thierry Reding , Jonathan Hunter , Jyri Sarha , Eric Anholt , Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , VMware Graphics , Roland Scheidegger , Zack Rusin , Hyun Kwon , Michal Simek , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org References: <20210219120032.260676-1-maxime@cerno.tech> <20210219120032.260676-2-maxime@cerno.tech> <51bb5aaf-f771-020b-9a48-77d8679de6a2@suse.de> <20210219151235.dsv4mujqyrzndhsn@gilmour> From: Thomas Zimmermann Message-ID: <2abb00b3-23d2-e652-4194-a10fbf171b88@suse.de> Date: Mon, 22 Feb 2021 10:01:56 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210219151235.dsv4mujqyrzndhsn@gilmour> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="w1lSYWSR69EiDDUmRFseCwFhMSFWd2baX" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --w1lSYWSR69EiDDUmRFseCwFhMSFWd2baX Content-Type: multipart/mixed; boundary="sEqTb7DLvEQPgunNTOiF1zujXM8e72iqO"; protected-headers="v1" From: Thomas Zimmermann To: Maxime Ripard Cc: Maarten Lankhorst , Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, Laurent Pinchart , Harry Wentland , Leo Li , Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= , Daniel Vetter , "James (Qian) Wang" , Liviu Dudau , Mihail Atanassov , Brian Starkey , Russell King , Dave Airlie , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Stefan Agner , Alison Wang , Xinliang Liu , Tian Tao , John Stultz , Xinwei Kong , Chen Feng , Laurentiu Palcu , Lucas Stach , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Paul Cercueil , Anitha Chrisanthus , Edmund Dea , Chun-Kuang Hu , Matthias Brugger , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Clark , Sean Paul , Ben Skeggs , Tomi Valkeinen , Gerd Hoffmann , Kieran Bingham , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Benjamin Gaignard , Vincent Abriou , Yannick Fertre , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Jernej Skrabec , Thierry Reding , Jonathan Hunter , Jyri Sarha , Eric Anholt , Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , VMware Graphics , Roland Scheidegger , Zack Rusin , Hyun Kwon , Michal Simek , amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-mips@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, nouveau@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org Message-ID: <2abb00b3-23d2-e652-4194-a10fbf171b88@suse.de> Subject: Re: [PATCH v3 02/11] drm: Rename plane atomic_check state names References: <20210219120032.260676-1-maxime@cerno.tech> <20210219120032.260676-2-maxime@cerno.tech> <51bb5aaf-f771-020b-9a48-77d8679de6a2@suse.de> <20210219151235.dsv4mujqyrzndhsn@gilmour> In-Reply-To: <20210219151235.dsv4mujqyrzndhsn@gilmour> --sEqTb7DLvEQPgunNTOiF1zujXM8e72iqO Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 19.02.21 um 16:12 schrieb Maxime Ripard: > Hi Thomas, >=20 > Thanks for your review! >=20 > On Fri, Feb 19, 2021 at 03:49:22PM +0100, Thomas Zimmermann wrote: >>> diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/= ipuv3-plane.c >>> index 075508051b5f..1873a155bb26 100644 >>> --- a/drivers/gpu/drm/imx/ipuv3-plane.c >>> +++ b/drivers/gpu/drm/imx/ipuv3-plane.c >>> @@ -337,12 +337,12 @@ static const struct drm_plane_funcs ipu_plane_f= uncs =3D { >>> }; >>> static int ipu_plane_atomic_check(struct drm_plane *plane, >>> - struct drm_plane_state *state) >>> + struct drm_plane_state *new_state) >> >> This function uses a different naming convention then the others? >> >>> { >>> struct drm_plane_state *old_state =3D plane->state; >=20 > So, the function already had a variable named old_state, so I was > actually trying to make the drivers consistent here: having one variabl= e > with old_state and new_plane_state felt weird. >=20 > The heuristic is thus to use the convention of the driver if one exists= > already, and if there's none pick new_plane_state. >=20 > It makes it indeed inconsistent across drivers, but it felt more natura= l > to be consistent within a single driver. Makes sense. >=20 > Maxime >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=FCrnberg, Germany (HRB 36809, AG N=FCrnberg) Gesch=E4ftsf=FChrer: Felix Imend=F6rffer --sEqTb7DLvEQPgunNTOiF1zujXM8e72iqO-- --w1lSYWSR69EiDDUmRFseCwFhMSFWd2baX Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmAzcwQFAwAAAAAACgkQlh/E3EQov+BQ PRAApEdNgQ+vqv+VzwVCbZGvaYSJtb908qPub+x6G/TOtgTxy8nU/+4qswCNV1TRb47fJcScii5P muJ5755oRh4YUO4NVEtX8GKHOgjfCwpAUXuwlWMs7HX4yxmi5IlBj1w5nsFNF88DhVuB+2AEFXkd ata8+bV5tpBKfULJcNvMYIG/sYzusZAf2m8hmCGpNKXC5Y1MkdVAaNzoZDmjOMdvyC8YVmiyuQYm XH6RqvBNEdrVf8QpbecMX946GtVx/ZYhheMzeojAjs6BSN56nkEbFyeDTDZy5Dj2exfMb7r4c2Md yXh3NGjtYAZc9AYFG5Gm23hEioOh1NeLQm5V2YA7FxtDqonl3w1pTvIBSdb/6tBAPFUWfiMOZIkI FgBteGCFHY7zTITnY+R0RGDY6oFZApyVwiXtxj2bybCEyBG7dHBAJ7ga+tRvT7fG5T94Q6y1cyKj v86blGFaPEZYZfeRbwrKbmwq/fbT6/OFH7eZLxzn5fLH1NJora6NM5gDXssJ77KwbVhbra2uzHuB uzpM8wC0JU7YFsd8boCIoxlST7QHttvFX8pSd///+Hub0U1/QXZPfQ4t0J1AheysqA/onDRoyd8U k3hPMvUtSmZwZSAGSO/6jzkR1Tki5qIgqmKJ6VDh8w7gpWSnDWkXcPiQlrNo4sWJnQQgDrL11BMb e3E= =cO2r -----END PGP SIGNATURE----- --w1lSYWSR69EiDDUmRFseCwFhMSFWd2baX--