Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1444038pxb;
        Mon, 22 Feb 2021 01:56:15 -0800 (PST)
X-Google-Smtp-Source: ABdhPJxNVmTo4xLpT6Nq5gfIk8xg/w8KBbx1MDXVjks8NhyBCjQDPAV7rWcgC9Xnco1jf5vndEOw
X-Received: by 2002:a17:906:2e89:: with SMTP id o9mr17212337eji.223.1613987775692;
        Mon, 22 Feb 2021 01:56:15 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1613987775; cv=none;
        d=google.com; s=arc-20160816;
        b=KQ78kRkTAd/l0g1LHPNrGfLzSh/tAYOgkprRMnnPeEsEB3c20CYL06kxzWNIW2WnjR
         b1GH7Yr68I3T+5ejL9o3qFbEHZHG1hWbpXKbLm2r6hePVoglQx2m7nHHPiwII4PdwPGk
         rRVScA157BxoCPzjdlF4qRBCV/8qvx7VLiWmXzLIJgRGBgpe6Sjdc1N29dOxbGFf53G/
         Ar1lcKZH5aCw6q/nfjCrNmHjzyq1KmlgK7DR37xk2eTgH7hRzdxioSplVB8cbxYq0ctX
         PVWgS2b+hzVLav/pKyobmF+4k42goN1tvCcYy9gvnk+aEVnkaSo6z66pLnBt96QnW/BX
         gg+g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=4INKZ+xKwXFwOug5v1O1XsX1s3Xkp/DPdSx2/VA7txo=;
        b=Yo6+GmenWQvwJAOwNbPQApNimIhD245VfFlsQQHRrFoK/vorbud5DD4XEy7nP7xFX/
         sodLMSZ6owBk533l6nXKkwwOo6z0tmsczy9be/ZTlPhxikLhBWJdzsoSeGhGryYE53hT
         dOS6Q3Xe7NBIbiyfcnlKRtsjUa78miOD3toLPHrWMtvyrqKnJv14yh7PXMrI73/6J4SF
         2HyOiIRbjiBbfYhMaqS12uZtrgvcHE3Uoc9J3+Ec9ZrqWQPWT/oEcxM4pYqnP7o6ETmD
         D3C0enSTAy7UkbC0fGybn/ugvx7e3/n2dmveL4J+3t1j3VCixPEL7KkPnYBkdrEbmmRO
         yT/A==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2va3FjJt;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id qp24si12153934ejb.109.2021.02.22.01.55.52;
        Mon, 22 Feb 2021 01:56:15 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2va3FjJt;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230295AbhBVJxw (ORCPT <rfc822;lsq991025@gmail.com> + 99 others);
        Mon, 22 Feb 2021 04:53:52 -0500
Received: from mail.kernel.org ([198.145.29.99]:51858 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S230044AbhBVJxu (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 Feb 2021 04:53:50 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id 5CA8864E2F;
        Mon, 22 Feb 2021 09:53:08 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1613987588;
        bh=BBG3yknKL0hoGSOg1hNme7zrwWCbVtcVbJuDn0H9qRo=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=2va3FjJtSZQupCjTYVzMxAyUZVVUbxhp9YPh7MLb2J8qpkpWPJQkQsuAXiQgnH5CW
         Y5PLKhfUqtCh3HifYAoGZ5ytxKRb7Wch2FiOaymmYibhqwjnJQjGZyPk4u2oZHrHeP
         QivH9UJCqqPRIVf9GwsBgmnDCZ9JQ/cBjnUJGlW4=
Date:   Mon, 22 Feb 2021 10:53:06 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Adrian Catangiu <acatan@amazon.com>
Cc:     linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        qemu-devel@nongnu.org, kvm@vger.kernel.org,
        linux-s390@vger.kernel.org, graf@amazon.com, rdunlap@infradead.org,
        arnd@arndb.de, ebiederm@xmission.com, rppt@kernel.org,
        0x7f454c46@gmail.com, borntraeger@de.ibm.com, Jason@zx2c4.com,
        jannh@google.com, w@1wt.eu, colmmacc@amazon.com, luto@kernel.org,
        tytso@mit.edu, ebiggers@kernel.org, dwmw@amazon.co.uk,
        bonzini@gnu.org, sblbir@amazon.com, raduweis@amazon.com,
        corbet@lwn.net, mst@redhat.com, mhocko@kernel.org,
        rafael@kernel.org, pavel@ucw.cz, mpe@ellerman.id.au,
        areber@redhat.com, ovzxemul@gmail.com, avagin@gmail.com,
        ptikhomirov@virtuozzo.com, gil@azul.com, asmehra@redhat.com,
        dgunigun@redhat.com, vijaysun@ca.ibm.com, oridgar@gmail.com,
        ghammer@redhat.com
Subject: Re: [PATCH v6 1/2] drivers/misc: sysgenid: add system generation id
 driver
Message-ID: <YDN/AvsplZ7R8OTR@kroah.com>
References: <1613986886-29493-1-git-send-email-acatan@amazon.com>
 <1613986886-29493-2-git-send-email-acatan@amazon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1613986886-29493-2-git-send-email-acatan@amazon.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 22, 2021 at 11:41:25AM +0200, Adrian Catangiu wrote:
> The driver also generates a `SYSGENID=%u` uevent containing the new
> system generation counter/id value every time it changes. Unlike the
> filesystem interface, the uevent has no synchronization guarantees
> therefore it should not be used by any sensitive system components.

No, please no.  It is not ok to start sending random uevents all the
time to userspace for individual drivers like this.  Especially for a
misc device.

As you say "has no synchromization guarantees", then why use it at all?

Please drop it.

thanks,

greg k-h