Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1452029pxb;
        Mon, 22 Feb 2021 02:11:39 -0800 (PST)
X-Google-Smtp-Source: ABdhPJyHMdrnuyyg6kHZeCfjQD2mPjGlWkUMa8Dh7MdbYBYRdhtPqjOvExjqb028w3Xq+3tlw9IT
X-Received: by 2002:aa7:d5d3:: with SMTP id d19mr20155159eds.216.1613988699490;
        Mon, 22 Feb 2021 02:11:39 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1613988699; cv=none;
        d=google.com; s=arc-20160816;
        b=CxSuhkDTwGf9+y0Q2vN248m2rqMiwkfkiPoJkvyXm2essd80Zv8fs+/t0KlTZKAaLE
         g2DR+czIMVM0V9bO5tdpWimyMv5qoUgkEPE57yu5xWjRqdPlp8dUdu84U/RKFNx6DXic
         CedzR5ZMW9bhPtNEz+Znvwi2zrAlYgia2EQQfCLgjxbyrE5zReuOF0XIO8jsCeFqITPc
         f6mxrgcKUDBL9VekJd/H1n3hxdYobdpAPvH/nqPrWs17cpdcKy3pb56LpbXm8c4bxdEd
         ne7kCpt9RKSurZpm82OXjvjQ2zFXD/Fwasrg1m1bY5FwxNvfFzIzb87AHZoE/t2E422G
         XFOQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=ma8MTpa/HAoIYU2Q1MpEZ5f2KXXnT+TVIKxovE2CQpU=;
        b=yEw2ltBUKDwffHP1Vdi4Wv5K099jUxkzsuVHTuBuHlB5pOLyz7w60MBZtZVtGaiaNn
         HdIUJooUHpeCxpsDj5LnBohNIa+n7N4Qdlsa615Mq6dAGNvSBqMicgfcmdQ1bRue0Hd/
         OWaHBsbLcj6u7BAsI7cFW8f9nk3wSGgpbiGALamfgMVEyfXXFWZQ9pNZmmvF4GcwQtdB
         vRu03HLxIMS5HeZ/lKYi01bSzPNAObZ4GKco7G05CvNfQW+OR9A9qeI9jmAqh5Sn519l
         XoZmLB29HmN+VV51LZ8KlZO4RYWwSsZrLhRxN2wdoJQAypD80yPY2orpBlTYoqofAp47
         NgAA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@alien8.de header.s=dkim header.b=bEexuLfS;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id b23si1955227ejc.658.2021.02.22.02.11.16;
        Mon, 22 Feb 2021 02:11:39 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@alien8.de header.s=dkim header.b=bEexuLfS;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230494AbhBVKH5 (ORCPT <rfc822;lsq991025@gmail.com> + 99 others);
        Mon, 22 Feb 2021 05:07:57 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58504 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230400AbhBVKEj (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 22 Feb 2021 05:04:39 -0500
Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18C0BC061574;
        Mon, 22 Feb 2021 02:03:59 -0800 (PST)
Received: from zn.tnic (p200300ec2f040200a034b7f44a0c99a8.dip0.t-ipconnect.de [IPv6:2003:ec:2f04:200:a034:b7f4:4a0c:99a8])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7C1BF1EC0323;
        Mon, 22 Feb 2021 11:03:57 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim;
        t=1613988237;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         content-transfer-encoding:in-reply-to:in-reply-to:  references:references;
        bh=ma8MTpa/HAoIYU2Q1MpEZ5f2KXXnT+TVIKxovE2CQpU=;
        b=bEexuLfS2GrmfGCk1rhZVJSCS1Mg1KHxQiH9ZgD7+a+cTq0TVVx6qksNl3POWsLMehkWS/
        8zQXCU/PyU1qaIX8s//s8sIFstPPaHfD1pTdS78iLfrHdTLvyGVxyiukPphk9mWrW5iCMD
        c6CgPbkJdZ7J5sZUQh+2q84j2Sv4rDM=
Date:   Mon, 22 Feb 2021 11:03:56 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Aili Yao <yaoaili@kingsoft.com>
Cc:     tony.luck@intel.com, mingo@redhat.com, tglx@linutronix.de,
        hpa@zytor.com, x86@kernel.org, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org, yangfeng1@kingsoft.com
Subject: Re: [PATCH v2] x86/mce: fix wrong no-return-ip logic in
 do_machine_check()
Message-ID: <20210222100356.GB29063@zn.tnic>
References: <20210222113124.35f2d552@alex-virtual-machine>
 <20210222115007.75b7de9b@alex-virtual-machine>
 <20210222092403.GA29063@zn.tnic>
 <20210222173109.7b7ac42a@alex-virtual-machine>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210222173109.7b7ac42a@alex-virtual-machine>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 22, 2021 at 05:31:09PM +0800, Aili Yao wrote:
> you can inject a memory UE to a VM, it should always be MCG_STATUS_RIPV 0.

So the signature you injected is not something the hardware would
generate - you just didn't set MCG_STATUS_RIPV.

If so, why should the code handle invalid signatures which the harware
cannot generate?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette