Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1453001pxb; Mon, 22 Feb 2021 02:13:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJycWur6E6AcOeEAJGpSeWMBk5aTzadgELVJ39p0RRKVAfpfEq75ipI/yFL+WNSa9QMKEDa1 X-Received: by 2002:a05:6402:a54:: with SMTP id bt20mr7110112edb.96.1613988793428; Mon, 22 Feb 2021 02:13:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613988793; cv=none; d=google.com; s=arc-20160816; b=Qb8kncarO0UgR9b6owrlqaGIpfsIsug82zeh49uYkVeG8OF89cZMgf51u4FDMXKmPt HFH/x3wxfMmPt9a//ubD+DmkpnMs1w5WAUvEurNtcpa65ysM0h++/CAlRvC22eWZA9Ka iWZQOcS8Xw3SC0+tUul0IKN0A/2vAh5F59nyJhedQGgjO1s5xBrKuzhn/t6K9/iNDvBf SIXKAeCku5Rot27xDHK/2sS5sh8U1xrLCty5xAEp19EhjlXPctaF25KfF+L+1YyHm3o1 I23RvBLdHIsxy7HaQf2tc96oUcuC9UMFhHG4vV7eeUlDGorEADvnUKgYgoLtk92yLWGA agCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=jMJRNKISOBGNc0oBzZsf07QPtMcwmEMGeSu426xbN5s=; b=ZFvvdbFSlJIDc0UouIvvlBn5PB1uIYBcGYqRGmBYjG3KVWgwV2R46QsmrDEPHJBVNC qD5gopY9+8whB+SkWiTKyjZLO/Ahsqn8odS2Ft0bJ2TMS1JxoqA2/oT5wU8mziLXSwhb WRz1OjrzBiLnrk8CFYGit25MoLSNV8cpF59fUQ2xEue8v09ptW6wNuClE4cSMEu7gXgd JdQ0SMuA1zHQeBabpZcoYzTkyMxW1ArtXvOrg1W2/M80tqg+LAoSX1o4J0dFVFX91vRm OExVK7LE2ijoC2Q0KHwZejwyjYgOMmySFTze/9JfmdhwRk/rqw2NJLeqfj405w+4oT9N G0dA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q22si11783509edc.553.2021.02.22.02.12.50; Mon, 22 Feb 2021 02:13:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230377AbhBVKMF (ORCPT + 99 others); Mon, 22 Feb 2021 05:12:05 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:12634 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230362AbhBVKIb (ORCPT ); Mon, 22 Feb 2021 05:08:31 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4Dkd9y69fqz16BRj; Mon, 22 Feb 2021 18:06:14 +0800 (CST) Received: from szvp000203569.huawei.com (10.120.216.130) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Mon, 22 Feb 2021 18:07:39 +0800 From: Chao Yu To: CC: , , , Chao Yu Subject: [PATCH] f2fs: check discard command number before traversing discard pending list Date: Mon, 22 Feb 2021 18:07:33 +0800 Message-ID: <20210222100733.120224-1-yuchao0@huawei.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.120.216.130] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In trim thread, let's add a condition to check discard command number before traversing discard pending list, it can avoid unneeded traversing if there is no discard command. Signed-off-by: Chao Yu --- fs/f2fs/segment.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index deaf57e13125..1e674c117ce3 100644 --- a/fs/f2fs/segment.c +++ b/fs/f2fs/segment.c @@ -1769,6 +1769,8 @@ static int issue_discard_thread(void *data) wait_ms = dpolicy.max_interval; continue; } + if (!atomic_read(&dcc->discard_cmd_cnt)) + continue; if (sbi->gc_mode == GC_URGENT_HIGH) __init_discard_policy(sbi, &dpolicy, DPOLICY_FORCE, 1); -- 2.29.2