Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1540549pxb; Mon, 22 Feb 2021 04:53:50 -0800 (PST) X-Google-Smtp-Source: ABdhPJxm3wYM0710mvEfPgjKsA0ZP4CuqjP2dJOO2OYIGuJZbMr52A4DaPxagfWVq8LESk8RyExg X-Received: by 2002:a17:906:bc9a:: with SMTP id lv26mr12890155ejb.152.1613998430645; Mon, 22 Feb 2021 04:53:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613998430; cv=none; d=google.com; s=arc-20160816; b=Mzggu/pnSCXzQjvoH8CUgak0ufGT7uIiZeEBxWDcMgLIYmcA6/KvmaOMhX21P2qDfd 4cvpafPfr2GdT0EeXwAni6ohuXWGzOL7tZdJto9jC1JQwtZg1O0y3MM54ooFX7VXqmWK bvERg2P3ihiXnb7yNxjZrwKsUDpLVIVLmsLpzHRNG3RKUkLX9XMCKVEtEMmFp/Nip4tZ suslgGvTm7N/U0M47x3Ff0APzYM1NCpuIIoNQk+2v3PskzxygyUmcq+Y/XLZW0PW6TfJ mY1FsFhOtK/F2U821ttUPp7at9WwDR0bh1qBBA5LjxcnSrM4wZAQ7+4mepEqiLYwj+5N c6bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NdKdxTJPMccx2CgGOp4zuI/H6JEWRng2ZU1fFtmYBv4=; b=B0+YdpK74UN5F9Rq3xjUn+ugQYRRWGWURjkSEBTBQr6EoYEJjiAA0oJj2i0Lx7GWOc P9lFnPpPKqXcq8inMwvM3Xte/fn/ywMNXWEWYntOrT8cANWFMmdE6TpJCZGgOCTo8xby a0ltIZIuZA2INEDMuJYrO77n9plq0BrM+B6yFSAWlPBPpWzjuh6WQ0C2PwpFaG8JdN8w lQoR0ycauBifiZ9QIVM8e9hO3gjhTSgeIE/mBq8oEiZkKBDVpd3EmVkcpYtq3en0s+38 lerRIHQg6nU+g4fz0my8JsV1kRg12scyWWK53vh7DWo1n0/Lnm+Po9Ocimzeq4yFnJ0x hM8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nxc6LCHx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a36si1204422edf.419.2021.02.22.04.53.28; Mon, 22 Feb 2021 04:53:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nxc6LCHx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231678AbhBVMws (ORCPT + 99 others); Mon, 22 Feb 2021 07:52:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:44746 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231158AbhBVMR7 (ORCPT ); Mon, 22 Feb 2021 07:17:59 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7771764E4B; Mon, 22 Feb 2021 12:17:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613996264; bh=Lp96/hbN9zF85s2USitS9aMGi0YbHNb+X/E9qNrrWbI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nxc6LCHxl65EyKJMlPrIBNel8IH6dkTk+2c9Inj+LIow6aKPlftND/qvuNkcGQdhv xW4YXkb7nbu6cZR7ejM1IY5ceZl2jRR2bMO9Xbq3r6otGPpL/MAEr1DqPBriFYR8VM 1ucRgGhh9p8N/KW84iH2UEx+fmsJ6HyMhazvZfZQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miklos Szeredi Subject: [PATCH 4.19 36/50] ovl: expand warning in ovl_d_real() Date: Mon, 22 Feb 2021 13:13:27 +0100 Message-Id: <20210222121026.317653245@linuxfoundation.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210222121019.925481519@linuxfoundation.org> References: <20210222121019.925481519@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miklos Szeredi commit cef4cbff06fbc3be54d6d79ee139edecc2ee8598 upstream. There was a syzbot report with this warning but insufficient information... Signed-off-by: Miklos Szeredi Signed-off-by: Greg Kroah-Hartman --- fs/overlayfs/super.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) --- a/fs/overlayfs/super.c +++ b/fs/overlayfs/super.c @@ -82,7 +82,7 @@ static void ovl_dentry_release(struct de static struct dentry *ovl_d_real(struct dentry *dentry, const struct inode *inode) { - struct dentry *real; + struct dentry *real = NULL, *lower; /* It's an overlay file */ if (inode && d_inode(dentry) == inode) @@ -101,9 +101,10 @@ static struct dentry *ovl_d_real(struct if (real && !inode && ovl_has_upperdata(d_inode(dentry))) return real; - real = ovl_dentry_lowerdata(dentry); - if (!real) + lower = ovl_dentry_lowerdata(dentry); + if (!lower) goto bug; + real = lower; /* Handle recursion */ real = d_real(real, inode); @@ -111,8 +112,10 @@ static struct dentry *ovl_d_real(struct if (!inode || inode == d_inode(real)) return real; bug: - WARN(1, "ovl_d_real(%pd4, %s:%lu): real dentry not found\n", dentry, - inode ? inode->i_sb->s_id : "NULL", inode ? inode->i_ino : 0); + WARN(1, "%s(%pd4, %s:%lu): real dentry (%p/%lu) not found\n", + __func__, dentry, inode ? inode->i_sb->s_id : "NULL", + inode ? inode->i_ino : 0, real, + real && d_inode(real) ? d_inode(real)->i_ino : 0); return dentry; }