Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1542992pxb; Mon, 22 Feb 2021 04:58:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJylo8GbfYq5b0d9JXhk0SHF4ihEVZTmO97NWY6W/YSl1p1BPUWCOdJl91HyRWnZCNlmm7ju X-Received: by 2002:aa7:d2c4:: with SMTP id k4mr4937775edr.237.1613998706988; Mon, 22 Feb 2021 04:58:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613998706; cv=none; d=google.com; s=arc-20160816; b=iVKUFACyGIcVWxKojAacjAR7eUc3eG7adaJF97yutc1czazChQB4vVylqcWEBGQ6LH 8TlM6o/4KoMhz8UYSRqhRUkEycnLb4wtZSsso76Uju2WLfgp3lmhg1RhcV1mm0Oj6Lej 3I2ihj2OYFkUZN5saolD2jABJT37UBSBNrRorE9LDPy0Y2GOKWBqCr5BCE8LGP5bb+gS 8oZ9JOe1X0VEokbgsXwp+CqdoGXcId7uWyvis3ckG2r350FYEkKjNRiBloJWtuwrCRsc RDrHU9zG559l8+9+piMKj3ohdEkbdV+OL0t+Grl2vgq7OyeJ3yYh6D2Yu1CZJekZHed2 yKTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=XXODBwd97b/14fLYT5f6AoZrhdOS9BEORM2yZlixmII=; b=ldztpSiKKko40FOAfWg9yqSkeqMeKMI2rf51FqReJxMCxfWDfjw6E7/wnGYt+fmV7t uADIlcaWEIfw97MVxKSxSwQrjsQ+iHcWd9LFivOVcAf2wC81Ru5x7xtdlLIyLNUiIdUu ukJe4SATIBIsBMWsRRv30WJHLzq1/jSml6+m5QprKIetveDjl1xVOaQwo5+ZJXM9a8jS GxnDFNuC5MudINz/Mtc+6Nx7NQWrdPihjGP7DvpppoVBgc8ZKGF5D/hH+PizYgvJwZ80 D7IrOCM9FthNNaZK5FrcTFnjfI/MZJ+9XJXLSkqd7MnhIU1Wr4GRvZxmDown9L2rvnWC FlYg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qw21si12160773ejb.103.2021.02.22.04.58.04; Mon, 22 Feb 2021 04:58:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231688AbhBVMzK (ORCPT + 99 others); Mon, 22 Feb 2021 07:55:10 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:12564 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231182AbhBVMVg (ORCPT ); Mon, 22 Feb 2021 07:21:36 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Dkh6x470jzMcf0; Mon, 22 Feb 2021 20:18:49 +0800 (CST) Received: from [10.67.110.218] (10.67.110.218) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.498.0; Mon, 22 Feb 2021 20:20:38 +0800 Subject: Re: [PATCH 4.9.257 1/1] futex: Fix OWNER_DEAD fixup To: Greg KH , Lee Jones CC: , , , , References: <20210222110542.3531596-1-zhengyejian1@huawei.com> <20210222110542.3531596-2-zhengyejian1@huawei.com> <20210222115424.GF376568@dell> From: "Zhengyejian (Zetta)" Message-ID: <4f06340a-e027-f944-3248-2939639d5e07@huawei.com> Date: Mon, 22 Feb 2021 20:20:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.110.218] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/2/22 20:07, Greg KH wrote: > On Mon, Feb 22, 2021 at 11:54:24AM +0000, Lee Jones wrote: >> On Mon, 22 Feb 2021, Zheng Yejian wrote: >> >>> From: Peter Zijlstra >>> >>> commit a97cb0e7b3f4c6297fd857055ae8e895f402f501 upstream. >>> >>> Both Geert and DaveJ reported that the recent futex commit: >>> >>> c1e2f0eaf015 ("futex: Avoid violating the 10th rule of futex") >>> >>> introduced a problem with setting OWNER_DEAD. We set the bit on an >>> uninitialized variable and then entirely optimize it away as a >>> dead-store. >>> >>> Move the setting of the bit to where it is more useful. >>> >>> Reported-by: Geert Uytterhoeven >>> Reported-by: Dave Jones >>> Signed-off-by: Peter Zijlstra (Intel) >>> Cc: Andrew Morton >>> Cc: Linus Torvalds >>> Cc: Paul E. McKenney >>> Cc: Peter Zijlstra >>> Cc: Thomas Gleixner >>> Fixes: c1e2f0eaf015 ("futex: Avoid violating the 10th rule of futex") >>> Link: http://lkml.kernel.org/r/20180122103947.GD2228@hirez.programming.kicks-ass.net >>> Signed-off-by: Ingo Molnar >>> Signed-off-by: Zheng Yejian >>> --- >>> kernel/futex.c | 7 +++---- >>> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> Reviewed-by: Lee Jones > > This does not apply to the 4.9.y tree at all right now, are you all sure > you got the backport correct? > > confused, > > greg k-h > . > I make the patch basing on 282aeb477a10 ("Linux 4.9.257"). Should I base on f0cf73f13b39 ("Linux 4.9.258-rc1")?