Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   IS20 Ofer Eilon <ofer.eilon@nuvoton.com>
To:     Avi Fishman <avifishman70@gmail.com>,
        Anton Kachalov <gmouse@google.com>
CC:     Tomer Maimon <tmaimon77@gmail.com>,
        Benjamin Fair <benjaminfair@google.com>,
        Tali Perry <tali.perry1@gmail.com>,
        Patrick Venture <venture@google.com>,
        Nancy Yuen <yuenn@google.com>,
        Rob Herring <robh+dt@kernel.org>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ARM: dts: nuvoton: Fix flash layout
Thread-Topic: [PATCH] ARM: dts: nuvoton: Fix flash layout
Thread-Index: AQHXCQSLzqaqyvos9EmAIN3K55QhcKpkNfMQ
Date:   Mon, 22 Feb 2021 14:10:52 +0000
Message-ID: <KL1PR0302MB255112AE01C81FEA63472A6293819@KL1PR0302MB2551.apcprd03.prod.outlook.com>
References: <20210218122546.3546582-1-gmouse@google.com>
 <CADKL2t6P4gaSUZEFgk7y+TNBRw0Lhf8mXTxzLdbe3FhGs0WH+w@mail.gmail.com>
 <CAP6Zq1jf4-XAhLQxqNx3LM7-YzDr8zaVPb-jznn8o=frxTotdQ@mail.gmail.com>
 <CADVsX89F6Tc0Zk6uB3CKRK0F8j_E+sVGHVb9FMAkHDQqJ+KBAQ@mail.gmail.com>
 <CAKKbWA7WL80C9h9xPcBNAHn-1=NBK9dh2Nqa1hO21hbdLEUbTw@mail.gmail.com>
In-Reply-To: <CAKKbWA7WL80C9h9xPcBNAHn-1=NBK9dh2Nqa1hO21hbdLEUbTw@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 87ee7955-a437-4ae1-57e2-08d8d73baa0c
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2021 14:10:52.5614
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a3f24931-d403-4b4a-94f1-7d83ac638e07
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Mn3ypXgvAP2PyHfquvfv1+4La9XydGHv1WIbU51DXbFaD5eGz5NDiIFwKYnpR4DtEUn0E+HJPWRwh0Wp8YEMFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KU1PR03MB2901
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Avi,

It seems an old version of uboot  u-boot_2019.01.7.5.bin  from igps below:

> https://apc01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithu=
b.com%2FNuvoton-Israel%2Figps%2Ftree%2Fmaster%2FImageGeneration%2Fversions&=
amp;data=3D04%7C01%7Cofer.eilon%40nuvoton.com%7Ce56881b8491d42e5ee4c08d8d71=
bacd4%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C637495861162860437%7CUnk=
nown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX=
VCI6Mn0%3D%7C1000&amp;sdata=3D0%2BNzEv%2FSX9QTg0XumchRrU61uGbZ3CZXrtspXu256=
0I%3D&amp;reserved=3D0

Please use latest from uboot.bin github.

Regards,
Ofer


-----Original Message-----
From: Avi Fishman <avifishman70@gmail.com>
Sent: Monday, February 22, 2021 12:21 PM
To: Anton Kachalov <gmouse@google.com>
Cc: Tomer Maimon <tmaimon77@gmail.com>; Benjamin Fair <benjaminfair@google.=
com>; Tali Perry <tali.perry1@gmail.com>; Patrick Venture <venture@google.c=
om>; Nancy Yuen <yuenn@google.com>; Rob Herring <robh+dt@kernel.org>; OpenB=
MC Maillist <openbmc@lists.ozlabs.org>; devicetree <devicetree@vger.kernel.=
org>; Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; IS20 Ofer E=
ilon <ofer.eilon@nuvoton.com>
Subject: Re: [PATCH] ARM: dts: nuvoton: Fix flash layout

Ofer,

Can you check why u-boot doesn't work with SD cards?

On Mon, Feb 22, 2021 at 11:27 AM Anton Kachalov <gmouse@google.com> wrote:
>
> Hi, Tom.
>
> Yes, I'm using it for testing on real hardware.
>
> BTW. Recent u-boot doesn't work with SD cards. The card doesn't
> detect. The last working version was this one:
>
> https://apc01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith
> ub.com%2FNuvoton-Israel%2Fnuvoton-info%2Ftree%2Fmaster%2Fnpcm7xx-poleg
> %2Fevaluation-board%2Fsw_deliverables%2Fnpcm7xx_v2.3&amp;data=3D04%7C01%
> 7Cofer.eilon%40nuvoton.com%7Ce56881b8491d42e5ee4c08d8d71bacd4%7Ca3f249
> 31d4034b4a94f17d83ac638e07%7C0%7C0%7C637495861162860437%7CUnknown%7CTW
> FpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
> Mn0%3D%7C1000&amp;sdata=3Df4t41g3CQaFTQNfwwNVBrIwQScndIGcfRTms0yrTn5o%3D
> &amp;reserved=3D0
>
> However, u-boot from igps repo:
>
> https://apc01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith
> ub.com%2FNuvoton-Israel%2Figps%2Ftree%2Fmaster%2FImageGeneration%2Fver
> sions&amp;data=3D04%7C01%7Cofer.eilon%40nuvoton.com%7Ce56881b8491d42e5ee
> 4c08d8d71bacd4%7Ca3f24931d4034b4a94f17d83ac638e07%7C0%7C0%7C6374958611
> 62860437%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiL
> CJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=3D0%2BNzEv%2FSX9QTg0Xumch
> RrU61uGbZ3CZXrtspXu2560I%3D&amp;reserved=3D0
>
> Has issues too. It doesn't allow me to read more than 4k bytes once at
> a time. Thus, to flash the stuff I have manually read chunks from the
> SD-card: fat load doesn't work at all and I write that data in raw
> partition.
>
> On Sun, 21 Feb 2021 at 17:40, Tomer Maimon <tmaimon77@gmail.com> wrote:
> >
> > Hi Benjamin and Anton,
> >
> > Sorry for the late reply,
> >
> > The EVB FIU0-CS0 partitioning is used for testing the EVB and this is w=
hy it is different than the OpenBMC flash layout.
> >
> >
> >
> > Are you using the NPCM7XX EVB for OpenBMC? if yes we can consider to mo=
dify the flash partition to OpenBMC use.
> >
> >
> > On Thu, 18 Feb 2021 at 19:11, Benjamin Fair <benjaminfair@google.com> w=
rote:
> >>
> >> On Thu, 18 Feb 2021 at 04:42, <gmouse@google.com> wrote:
> >> >
> >> > From: "Anton D. Kachalov" <gmouse@google.com>
> >> >
> >> > This change satisfy OpenBMC requirements for flash layout.
> >> >
> >> > Signed-off-by: Anton D. Kachalov <gmouse@google.com>
> >> > ---
> >> >  arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 28
> >> > +++++++----------------
> >> >  1 file changed, 8 insertions(+), 20 deletions(-)
> >> >
> >> > diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> >> > b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> >> > index bd1eb6ee380f..741c1fee8552 100644
> >> > --- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> >> > +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> >> > @@ -182,8 +182,8 @@ bbuboot2@80000 {
> >> >                                 reg =3D <0x0080000 0x80000>;
> >> >                                 read-only;
> >> >                                 };
> >> > -                       envparam@100000 {
> >> > -                               label =3D "env-param";
> >> > +                       ubootenv@100000 {
> >> > +                               label =3D "u-boot-env";
> >> >                                 reg =3D <0x0100000 0x40000>;
> >> >                                 read-only;
> >> >                                 }; @@ -195,25 +195,13 @@
> >> > kernel@200000 {
> >> >                                 label =3D "kernel";
> >> >                                 reg =3D <0x0200000 0x400000>;
> >> >                                 };
> >> > -                       rootfs@600000 {
> >> > -                               label =3D "rootfs";
> >> > -                               reg =3D <0x0600000 0x700000>;
> >> > +                       rofs@780000 {
> >> > +                               label =3D "rofs";
> >> > +                               reg =3D <0x0780000 0x1680000>;
> >> >                                 };
> >> > -                       spare1@D00000 {
> >> > -                               label =3D "spare1";
> >> > -                               reg =3D <0x0D00000 0x200000>;
> >> > -                               };
> >> > -                       spare2@0F00000 {
> >> > -                               label =3D "spare2";
> >> > -                               reg =3D <0x0F00000 0x200000>;
> >> > -                               };
> >> > -                       spare3@1100000 {
> >> > -                               label =3D "spare3";
> >> > -                               reg =3D <0x1100000 0x200000>;
> >> > -                               };
> >> > -                       spare4@1300000 {
> >> > -                               label =3D "spare4";
> >> > -                               reg =3D <0x1300000 0x0>;
> >> > +                       rwfs@1e00000 {
> >> > +                               label =3D "rwfs";
> >> > +                               reg =3D <0x1e00000 0x200000>;
> >> >                         };
> >>
> >> I recommend just including the openbmc-flash-layout.dtsi file here
> >> instead since that contains the common flash layout for most
> >> OpenBMC systems.
> >>
> > Good solution,
> > Do you mean nuvoton-openbmc-flash-layout?
> >>
> >> >                 };
> >> >         };
> >> > --
> >> > 2.30.0.478.g8a0d178c01-goog
> >> >
> >
> >
> > Thanks,
> >
> > Tomer


--
Regards,
Avi
________________________________
________________________________
 The privileged confidential information contained in this email is intende=
d for use only by the addressees as indicated by the original sender of thi=
s email. If you are not the addressee indicated in this email or are not re=
sponsible for delivery of the email to such a person, please kindly reply t=
o the sender indicating this fact and delete all copies of it from your com=
puter and network server immediately. Your cooperation is highly appreciate=
d. It is advised that any unauthorized use of confidential information of N=
uvoton is strictly prohibited; and any information in this email irrelevant=
 to the official business of Nuvoton shall be deemed as neither given nor e=
ndorsed by Nuvoton.