Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] certs: Add support for using elliptic curve keys for
 signing modules
To:     Mimi Zohar <zohar@linux.ibm.com>,
        Stefan Berger <stefanb@linux.vnet.ibm.com>,
        keyrings@vger.kernel.org, dhowells@redhat.com, dwmw2@infradead.org,
        linux-security-module@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
        nayna@linux.ibm.com, saulo.alessandre@gmail.com
References: <20210219154114.2416778-1-stefanb@linux.vnet.ibm.com>
 <0e2a789456a970ebdde9a65717b15d478af73ae3.camel@linux.ibm.com>
From:   Stefan Berger <stefanb@linux.ibm.com>
Message-ID: <e96a24ea-be12-616e-09dc-f8cffa56bee9@linux.ibm.com>
Date:   Mon, 22 Feb 2021 08:33:34 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <0e2a789456a970ebdde9a65717b15d478af73ae3.camel@linux.ibm.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

On 2/19/21 11:52 AM, Mimi Zohar wrote:
> On Fri, 2021-02-19 at 10:41 -0500, Stefan Berger wrote:
>> From: Stefan Berger <stefanb@linux.ibm.com>
>>
>> This patch adds support for using elliptic curve keys for signing
>> modules. It uses a NIST P256 (prime256v1) key if the user chooses an
>> elliptic curve key.
>>
>> A developer choosing an ECDSA key for signing modules has to manually
>> delete the signing key (rm certs/signing_key.*) when falling back to
>> an older version of a kernel that only supports RSA key since otherwise
>> ECDSA-signed modules will not be usable when that older kernel runs.
>>
>> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
> Thanks, Stefan!
>
> Tested with this patch applied on top of "[PATCH v8 0/4] Add support
> for x509 certs with NIST p256 and p192" and "[PATCH v2 0/5] ima: kernel
> build support for loading the kernel module" patch sets.

With Saulo's NIST p384 support we will now be able to improve this patch 
to use secp384r1 (NIST P384), which is probably the better equivalent to 
the current RSA 4096.


 ?? Stefan


>
> Tested-by: Mimi Zohar <zohar@linux.ibm.com>
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
>