Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965334AbWI0FQG (ORCPT ); Wed, 27 Sep 2006 01:16:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965335AbWI0FQG (ORCPT ); Wed, 27 Sep 2006 01:16:06 -0400 Received: from xenotime.net ([66.160.160.81]:46524 "HELO xenotime.net") by vger.kernel.org with SMTP id S965334AbWI0FQD (ORCPT ); Wed, 27 Sep 2006 01:16:03 -0400 Date: Tue, 26 Sep 2006 22:17:18 -0700 From: Randy Dunlap To: Joe Perches Cc: Greg KH , Jesper Juhl , Linux Kernel Mailing List Subject: Re: Tiny error in printk output for clocksource : a3:<6>Time: acpi_pm clocksource has been installed. Message-Id: <20060926221718.7e20613e.rdunlap@xenotime.net> In-Reply-To: <1159333843.13196.6.camel@localhost> References: <9a8748490609261722g557eaeeayc148b5f5d910874d@mail.gmail.com> <20060926173347.04fd66dd.rdunlap@xenotime.net> <200609270236.58148.jesper.juhl@gmail.com> <20060926205415.98b8d95d.rdunlap@xenotime.net> <20060927043239.GA32082@kroah.com> <20060926215235.16c987c0.rdunlap@xenotime.net> <20060926215622.f128d9fa.rdunlap@xenotime.net> <1159333843.13196.6.camel@localhost> Organization: YPO4 X-Mailer: Sylpheed version 2.2.9 (GTK+ 2.8.10; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1186 Lines: 33 On Tue, 26 Sep 2006 22:10:43 -0700 Joe Perches wrote: > On Tue, 2006-09-26 at 21:56 -0700, Randy Dunlap wrote: > > > Nope, that's part of the NIC's MAC address. It was split up. > > > > Sorry. In this case, it was via-rhine.c: > > > > for (i = 0; i < 5; i++) > > printk("%2.2x:", dev->dev_addr[i]); > > printk("%2.2x, IRQ %d.\n", dev->dev_addr[i], pdev->irq); > > > > so it does break the printk()s up itself. > > Changing all of those MAC address printks to a single function > could prevent this. > > http://www.uwsg.iu.edu/hypermail/linux/net/0602.1/0002.html True enough. Thanks for the patch. However, in this case, the single-printed MAC address still needs a \n, with the IRQ on a separate line (wasting vertical screen space), or it needs a custom printk() that is all done at one time. Probably the latter IMO. Oh, it looks like your patch has a way to handle that too. Good. What happened to your patch? --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/