Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 22 Feb 2021 19:44:17 +0100
From:   Krzysztof Kozlowski <krzk@kernel.org>
To:     Heiko Thiery <heiko.thiery@gmail.com>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        Rob Herring <robh+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Li Yang <leoyang.li@nxp.com>, Michael Walle <michael@walle.cc>
Subject: Re: [PATCH v2 2/2] arm64: dts: fsl: add support for Kontron
 pitx-imx8m board
Message-ID: <20210222184417.4nkmdjkgub73b2xd@kozik-lap>
References: <20210222140756.713-1-heiko.thiery@gmail.com>
 <20210222140756.713-3-heiko.thiery@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210222140756.713-3-heiko.thiery@gmail.com>
Precedence: bulk

On Mon, Feb 22, 2021 at 03:07:56PM +0100, Heiko Thiery wrote:
> The Kontron pitx-imx8m board is based on an i.MX8MQ soc.
> 
> Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
> ---
> v2:
>  - bring root nodes in alphabetical order
>  - remove pinctrl_gpio_keys for pciewake
>  - remove pinctrl_sai2 and pinctrl_spdfif1 since it is not used yet
> 
>  Thanks to Michael Walle:
>  - add pinctrl for regulator-v-3v3-sd
>  - add name for regulator swbst
>  - add comment about currently unused audio codec
>  - put usb_phy entry in correct alphabetical order
> 
>  Thanks to Krzysztof Kozlowski:
>  - use generic names for pcie-refclk, tpm, fan-controller, sensor
>  - remove empty line
>  - fix group name to match schema (ecspi2cs -> ecspi2csgrp)
> 
> 
>  arch/arm64/boot/dts/freescale/Makefile        |   1 +
>  .../freescale/imx8mq-kontron-pitx-imx8m.dts   | 641 ++++++++++++++++++
>  2 files changed, 642 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> 

Looks fine to me, also with the changes pointed out by Micahel in other
email in this thread:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof