Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965337AbWI0FUB (ORCPT ); Wed, 27 Sep 2006 01:20:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965341AbWI0FUB (ORCPT ); Wed, 27 Sep 2006 01:20:01 -0400 Received: from DSL022.labridge.com ([206.117.136.22]:33555 "EHLO Perches.com") by vger.kernel.org with ESMTP id S965337AbWI0FT7 (ORCPT ); Wed, 27 Sep 2006 01:19:59 -0400 Subject: Re: Tiny error in printk output for clocksource : a3:<6>Time: acpi_pm clocksource has been installed. From: Joe Perches To: Randy Dunlap Cc: Greg KH , Jesper Juhl , Linux Kernel Mailing List In-Reply-To: <20060926221718.7e20613e.rdunlap@xenotime.net> References: <9a8748490609261722g557eaeeayc148b5f5d910874d@mail.gmail.com> <20060926173347.04fd66dd.rdunlap@xenotime.net> <200609270236.58148.jesper.juhl@gmail.com> <20060926205415.98b8d95d.rdunlap@xenotime.net> <20060927043239.GA32082@kroah.com> <20060926215235.16c987c0.rdunlap@xenotime.net> <20060926215622.f128d9fa.rdunlap@xenotime.net> <1159333843.13196.6.camel@localhost> <20060926221718.7e20613e.rdunlap@xenotime.net> Content-Type: text/plain Date: Tue, 26 Sep 2006 22:19:53 -0700 Message-Id: <1159334393.13196.9.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.8.0-1mdv2007.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1003 Lines: 22 On Tue, 2006-09-26 at 22:17 -0700, Randy Dunlap wrote: > > > so it does break the printk()s up itself. > > Changing all of those MAC address printks to a single function > > could prevent this. > > http://www.uwsg.iu.edu/hypermail/linux/net/0602.1/0002.html > True enough. Thanks for the patch. > However, in this case, the single-printed MAC address still needs > a \n, with the IRQ on a separate line (wasting vertical screen space), > or it needs a custom printk() that is all done at one time. > Probably the latter IMO. Oh, it looks like your patch > has a way to handle that too. Good. > What happened to your patch? I sent it as an RFC with samples and such. It's out of date and it went comment free. I could bring it forward if anyone wants it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/