Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210222173541.GA1677515@robh.at.kernel.org>
In-Reply-To: <20210222173541.GA1677515@robh.at.kernel.org>
From:   Linus Torvalds <torvalds@linux-foundation.org>
Date:   Mon, 22 Feb 2021 10:52:09 -0800
Message-ID: <CAHk-=wi60wC2z0yTo+B81x8HNu2HVJ6mSFHJC3xpKJOW9_EV_g@mail.gmail.com>
Subject: Re: [GIT PULL] Devicetree updates for v5.12
To:     Rob Herring <robh@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Frank Rowand <frowand.list@gmail.com>,
        Michael Ellerman <mpe@ellerman.id.au>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 22, 2021 at 9:35 AM Rob Herring <robh@kernel.org> wrote:
>
> Please pull DT updates for v5.12.

Ugh.

This causes "git status" to be unhappy, because there's a new
generated file (scripts/dtc/fdtoverlay) without a gitignore entry.

This was added by commit 79edff12060f ("scripts/dtc: Update to
upstream version v1.6.0-51-g183df9e9c2b9"), and then enabled in commit
0da6bcd9fcc0 ("scripts: dtc: Build fdtoverlay tool"). But it was
already referenced before it was even added (by commit b775f49fbc8b:
"scripts: dtc: Fetch fdtoverlay.c from external DTC project", which
didn't actually fetch that thing at all!)

And that commit 79edff12060f is all kinds of strange anyway, in that
it *claims* to have taken some (other) gitignore updates from the
upstream dtc code, but it very clearly does no such thing.

So I have to say - that whole thing was done very very badly. Actively
incorrect commit messages, complete mess about when things were added,
and the end result isn't great.

Sadly, I only noticed after I had pulled and pushed out.

Please fix. Not just the current mess with the incomplete .gitignore
file, but the whole clearly broken workflow.

               Linus