Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210218123327.25486-1-heiko.thiery@gmail.com>
 <20210218123327.25486-3-heiko.thiery@gmail.com> <20210221121111.nsenzgenwb6pu3o7@kozik-lap>
 <CAEyMn7YN4xqcFxR0QHUDp8cc1QP62HgpGMCYAjh0RfWL-iRQCA@mail.gmail.com>
 <20210222084027.jd3eop7j4czoqqim@kozik-lap> <CAEyMn7YPNRDbPH84wg2s+r2F6Fo=0DJOUd-R03Fg=6_CxgknSg@mail.gmail.com>
In-Reply-To: <CAEyMn7YPNRDbPH84wg2s+r2F6Fo=0DJOUd-R03Fg=6_CxgknSg@mail.gmail.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Mon, 22 Feb 2021 19:38:47 +0100
Message-ID: <CAJKOXPdhbwpEHA+h3706NXf0uRhyu8VVC++K8WpzA6h2=8PK8Q@mail.gmail.com>
Subject: Re: [PATCH 2/2] arm64: dts: fsl: add support for Kontron pitx-imx8m board
To:     Heiko Thiery <heiko.thiery@gmail.com>
Cc:     linux-arm-kernel@lists.infradead.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Li Yang <leoyang.li@nxp.com>, Michael Walle <michael@walle.cc>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 22 Feb 2021 at 10:09, Heiko Thiery <heiko.thiery@gmail.com> wrote:
> > > > > +
> > > > > +     pcie0_refclk: pcie0-refclk {
> > > >
> > > > Generic node names (from the dt spec candidate is "clock").
> > >
> > > Should I simply set the node name to pcie0-clock? And pcie1-clock for
> > > the next one?
> >
> > I am fine with "pcie0-clock" or just "clock-0".
>
> I saw now that in "imx8mq-zii-ultra.dtsi" the name
> "clock-pcie0-refclk" is used. Can I use the same?

It's not that generic anymore - but specific, but it's also not that
important, so go ahead.

> > >
> > > When I run "make dtbs_check" it runs quite a long time and stops with
> > > an error. But as far as I can say there is an error coming from the
> > > included "imx8mq.dtsi".
> > >
> > > You can see the output here: https://pastebin.com/raw/iU2geBDh
> >
> > Looks fine (except the error tool :) ).
>
> What do you mean with error tool?

I lost some words on the wire - I meant: "except the error from the
tool itself".

Best regards,
Krzysztof