Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 1/3] add params and ids to support nist_p384
To:     Saulo Alessandre <saulo.alessandre@gmail.com>
Cc:     davem@davemloft.net, dhowells@redhat.com,
        herbert@gondor.apana.org.au, keyrings@vger.kernel.org,
        linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org,
        linux-kernel@vger.kernel.org, patrick@puiterwijk.org,
        zohar@linux.ibm.com, Saulo Alessandre <saulo.alessandre@tse.jus.br>
References: <20210215162532.1077098-1-stefanb@linux.ibm.com>
 <20210222175850.1131780-1-saulo.alessandre@gmail.com>
From:   Stefan Berger <stefanb@linux.ibm.com>
Message-ID: <2e829730-bb0c-47eb-70f2-731c184eba33@linux.ibm.com>
Date:   Mon, 22 Feb 2021 13:37:41 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20210222175850.1131780-1-saulo.alessandre@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

On 2/22/21 12:58 PM, Saulo Alessandre wrote:
> From: Saulo Alessandre <saulo.alessandre@tse.jus.br>
>
> * crypto/asymmetric_keys/x509_cert_parser.c
>    - prepare x509 parser to load nist_secp384r1
>
> * crypto/ecc_curve_defs.h
>    - add nist_p384 params
>
> * include/crypto/ecdh.h
>    - add ECC_CURVE_NIST_P384
>
> * include/linux/oid_registry.h
>    - reorder OID_id_ecdsa_with_sha1
>    - add OID_id_secp384r1
>
> Signed-off-by: Saulo Alessandre <saulo.alessandre@tse.jus.br>

I would separate this patch into an x509: and certs: part since it 
touches two subsystems.

I can take this series of patches and post my v9 including them at the 
end. This would make it easier for others to test. I would massage them 
a bit, including the separation of the 1st patch into 2 patches, if you 
don't mind, preserving your Signed-off-by. I need to fix something in my 
v8 regarding registration failure handling. Let me know whether this is 
fine with you.

I had tested your patches over the weekend with my endless test tool 
creating keys in user space and loading them into the kernel. It worked 
fine for NIST p256 & p384. Also signing kernel modules with NIST p384 is 
working fine.

So, for the series:

Tested-by: Stefan Berger <stefanb@linux.ibm.com>

Regards,

     Stefan