Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2124895pxb; Mon, 22 Feb 2021 21:56:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJw/0GS+OSZn49ILm0aL+/on2hJrS234ls+OFaQCK0J3Ch42QRm5uwPKL2GGb+eEBFtvu4za X-Received: by 2002:aa7:c90f:: with SMTP id b15mr17748363edt.51.1614059788242; Mon, 22 Feb 2021 21:56:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614059788; cv=none; d=google.com; s=arc-20160816; b=NidaHif/pIMSEAd4B95DNZ3JzcTeaQ8GZywZIyGXqDbI9chmmoXJ2qo24uC8zQ723X 3YWhGb+db/xMEBL2pwfnwLB3G2Vt2a0IQLejrUCAEF4gVbOfTtB1b6SKUpfHhmNwr+6w u4t/AblP3n1p85GxdDglDzF+3WURDFF+aVVGOLCIZEmfDFJedJDrXo60uogeymRttkIj v/mJ5o1f5ixicm4yUs+8dl0pBfQO5i3FWaMY/al1Ys3LE8Sfu4oMb5IbMCrREe23zVQl drxpIYmmMp6qf1jA0KMhYEYyEdWzsFkTPqMPiiJbgYnkxCAv0gNY2U5u4oKYZFcTYU0K Gfcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=/xQVPH+tBRPlkb3Yd4eaw2JeYKHzS6sUf0I+wcp7YFY=; b=k9nzc+ZCqL0DD3UYx/G5JyfRb00YhwX90OJg/4ijhXG38KkDuWPSIJgxiAON+UjcLj Pz7WxJ3mvnJcJIaukYbp/dHQ0d8RXH5O/YLtDdHiZqWYZaN/WG3IkgmlKkjFvSabY0pv REFr2Xxl05HsdZf4cY/eq/yNSDm6G6NjBpq1yVBk8MJO2kVshwybqUmDU+WPd4Pkd3Rg KGp/oUdFxypKv96dnr3+qUK4GZInc7osoCL0qV3XZZlBRGG5anpb4ezCQHPLlp+KVICk TJy230PkGaYplIGmDpSO/XM++e5x9THMgEQ4PJynJjrYbf5GZ728jB2S1fg8uAWIdREL uPDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e4si1274361eja.397.2021.02.22.21.56.02; Mon, 22 Feb 2021 21:56:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231648AbhBWFzC (ORCPT + 99 others); Tue, 23 Feb 2021 00:55:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231284AbhBWFy7 (ORCPT ); Tue, 23 Feb 2021 00:54:59 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E587AC061793 for ; Mon, 22 Feb 2021 21:53:40 -0800 (PST) Received: from dude.hi.pengutronix.de ([2001:67c:670:100:1d::7]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lEQdP-0005FP-Hw; Tue, 23 Feb 2021 06:53:23 +0100 Received: from ore by dude.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1lEQdO-000128-D3; Tue, 23 Feb 2021 06:53:22 +0100 From: Oleksij Rempel To: mkl@pengutronix.de, "David S. Miller" , Jakub Kicinski , Oliver Hartkopp , Robin van der Gracht , Johannes Berg Cc: Oleksij Rempel , kernel@pengutronix.de, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Dumazet , linux-wireless@vger.kernel.org Subject: [PATCH net v2 0/2] add support for skb with sk ref cloning Date: Tue, 23 Feb 2021 06:53:18 +0100 Message-Id: <20210223055321.3891-1-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org changes v2: - drop mac80211 patch for now, it can go separately if needed Hello, this series tries to fix a long standing problem in the CAN echo SKB handling. The problem shows up if an echo SKB for a SKB that references an already closed socket is created. It looks like the mac80211/tx.c has the same problem, see RFC patch 3 for details. regards, Oleksij Oleksij Rempel (2): skbuff: skb_clone_sk_optional(): add function to always clone a skb and increase refcount on sk if valid can: fix ref count warning if socket was closed before skb was cloned include/linux/can/skb.h | 3 +-- include/linux/skbuff.h | 1 + net/can/af_can.c | 6 +++--- net/can/j1939/main.c | 3 +-- net/can/j1939/socket.c | 3 +-- net/can/j1939/transport.c | 4 +--- net/core/skbuff.c | 27 +++++++++++++++++++++++++++ 7 files changed, 35 insertions(+), 12 deletions(-) -- 2.29.2