Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 23 Feb 2021 14:14:40 +0900
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     David Lechner <david@lechnology.com>
Cc:     Jonathan Cameron <jic23@kernel.org>, kernel@pengutronix.de,
        linux-stm32@st-md-mailman.stormreply.com, a.fatoum@pengutronix.de,
        kamel.bouhara@bootlin.com, gwendal@chromium.org,
        alexandre.belloni@bootlin.com, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        syednwaris@gmail.com, patrick.havelange@essensium.com,
        fabrice.gasnier@st.com, mcoquelin.stm32@gmail.com,
        alexandre.torgue@st.com, o.rempel@pengutronix.de
Subject: Re: [PATCH v8 12/22] counter: Rename counter_count_function to
 counter_function
Message-ID: <YDSPQFMd0sqUBUaq@shinobu>
References: <cover.1613131238.git.vilhelm.gray@gmail.com>
 <355aaaaf44b36c5de1704e4074a4671abcb9699d.1613131238.git.vilhelm.gray@gmail.com>
 <20210214171340.3cc7b686@archlinux>
 <2b6913ac-0802-f83e-06ba-e89d5318dbd7@lechnology.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="CvbW7fZyFWvbVNT8"
Content-Disposition: inline
In-Reply-To: <2b6913ac-0802-f83e-06ba-e89d5318dbd7@lechnology.com>
Precedence: bulk


--CvbW7fZyFWvbVNT8
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Feb 20, 2021 at 10:56:13AM -0600, David Lechner wrote:
> On 2/14/21 11:13 AM, Jonathan Cameron wrote:
> > On Fri, 12 Feb 2021 21:13:36 +0900
> > William Breathitt Gray <vilhelm.gray@gmail.com> wrote:
> >=20
> >> The phrase "Counter Count function" is verbose and unintentionally
> >> implies that function is a Count extension. This patch adjusts the
> >> Counter subsystem code to use the more direct "Counter function" phrase
> >> to make the intent of this code clearer. The phrase "Count action" is
> >> adjusted herein as well for the same reason.
> >>
> >> Cc: Syed Nayyar Waris <syednwaris@gmail.com>
> >> Cc: Patrick Havelange <patrick.havelange@essensium.com>
> >> Cc: Kamel Bouhara <kamel.bouhara@bootlin.com>
> >> Cc: Fabrice Gasnier <fabrice.gasnier@st.com>
> >> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> >> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> >> Cc: David Lechner <david@lechnology.com>
> >> Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
> >=20
> > I agree this makes sense in the counter core code, but in the drivers
> > it may not be quite so obvious we are talking about a counter function
> > given some of the bits of hardware do a number of other things.
> >=20
> > I guess up to the various driver maintainers on whether they
> > think the new meaning is clear enough!
> >=20
> > Jonathan
> >=20
>=20
> TBH, I think "counter count function" makes more sense to me.

That's a fair point. I'll revert this for the individual drivers and
leave it up to the maintainers if they want to adjust their namings.
Instead, I'll limit the name changes to the counter core code.

William Breathitt Gray


--CvbW7fZyFWvbVNT8
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmA0jzYACgkQhvpINdm7
VJLBQg/9GFXoFuC1SgrhZBOf3aVmvp31oECQ/jZrZRo78seSdAy7lyxzby6V8asO
adikRiaumev/b4NJStCUMH9qZ7P+nGRI74Yhd0HFaowh3vHm4DKBZfxcwOuh9sL7
8AUUpqaWFYXPnTn7G/JJv2nVGGlFH8FecIqOjYroMHhI6b8PiueMgqhHnL4bxlyX
AP1zJYt+EztFOCiLB4hglEbc/qS8lTzqE0qcBwAF8RaUC+bqeiFNb3HrrnT7j1dw
j+4o9KyuJ8crppn81jlvU54MM457MMh01sAW6KnvFWxFaUXE7LI/jAV0v3vuX4yi
Ag9kSHRT8zTkPtcQSFApcjwaWRVC7bkvmOLuNl3X4JDJtqb5soVvf5vULzBiUcrf
DtwK3Xiw7LXV8stKJsz8Ot9xASj47e+R6tmJZFmCDvb/M4zK3CZOAmZvYGuxv81t
Mi3SM1MyIBZScC+5Pjydxf5kxpTKfcTYoKYaZ/szQtO3bQMP5iyuiKlInnvj0JSv
ZP89E8JBuihK3C0HGLx4vx3L8n8qaXzoBfkPijnZh+RD2FmTGHuws7YSVkbdApao
jhSh+GnWr6kc+sH/Jo3QhU7I/rwtscxPmtKuhrptLt1D6C9zR6AKgmNWgd8jb9pX
OfT2odtPtlnQZZONRO/UgPnQYk2rWTGvOaaz+gerWbsAzIHiEvM=
=tRzo
-----END PGP SIGNATURE-----

--CvbW7fZyFWvbVNT8--