Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2140165pxb; Mon, 22 Feb 2021 22:27:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJwuEHgI23QcCnyzVSe3GLsM+Ad4zbWwxJ7t8/qL7IZaZ1rKIjQq/X/oRd5eF0WpTdqZ6Hhf X-Received: by 2002:a05:6402:3494:: with SMTP id v20mr27045722edc.146.1614061652921; Mon, 22 Feb 2021 22:27:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614061652; cv=none; d=google.com; s=arc-20160816; b=hBAAwuOABjj/GpiKL6RRvuDw1I0ZmoqR2pe3kH+Lj+6Fa8UBO02U4moVcCI1vGKLJH jhQgE/X/bwmAhiGC3JC4NfkRZwyrjvfbmr3j0PwswQoTyPZV+ETxMVexzOe/lvWWVwVX HXAIA6AvFAXVyurTI+HN1ZO6R3n7digCM4vx2yv02Yf+Y3C2sDyTakzif/CLhKumvGaI XvqRZdJ35gK7Dwpw1odQTnL3x764XynS/ntZCCoBt2nnZQJv6BgvR/oi/N6KBzuBTT9p WEa0ORMmfdWeHkW/a0MS1KKg1g1Z56sLDvL4vH7KEHHLsYkW/gMdaNMu7gEBylfxfziW s2BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature:dkim-filter; bh=lUNtrJvctvJzEcm1zYcLcrAroXBINRuq0RjqjDVmyfs=; b=aaTHksgmudI/joci5IeGEpNRLkrrZTbPHV/guDiLUSdTT2jDq94LzDfY8I8/4dgCSj 7fDkkQTN+tjiIGpqFKmE0UMCFrHmOJTDNRJGRUXhbylql29IZKQdbvhtQ8tw1OQ3hAK4 tADj/XbiipVeR51Mrfzhub94vV8ORr8XemGllIbz3HxX+EBX1Hzpo+4//UB+qb0c1zjJ ECl2HsPUN/1zDlTZ3UZMIb4vB1hPy3BuTi1wCEK33EFcd9uLm4Lt9KRLaOL+Ncfs+cD7 gJdHgyYFIxZqY+vIPhNNed7EIlm2viBJpm9sJuVcW4QJLSGD8ZoTOsSKcciot4xVzb2J xLqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b="KT2/lZB4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v5si12744535eji.385.2021.02.22.22.27.07; Mon, 22 Feb 2021 22:27:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b="KT2/lZB4"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231284AbhBWGSJ (ORCPT + 99 others); Tue, 23 Feb 2021 01:18:09 -0500 Received: from linux.microsoft.com ([13.77.154.182]:56442 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230349AbhBWGSF (ORCPT ); Tue, 23 Feb 2021 01:18:05 -0500 Received: from [192.168.0.114] (unknown [49.207.208.227]) by linux.microsoft.com (Postfix) with ESMTPSA id 6B99520B6C40; Mon, 22 Feb 2021 22:17:23 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 6B99520B6C40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1614061045; bh=lUNtrJvctvJzEcm1zYcLcrAroXBINRuq0RjqjDVmyfs=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=KT2/lZB44jCwhVMbSkk7ge2xvbpsHiCOTJmKxL+Igd5gJFpX48A56PJgYHZW+tcur OVVNTThZnd5E9/O71bUH76bQdH/kUvv2W5ntL0odWEzIKEGpB1+ZzSwBVljO1fHosT k9k+fEv2UIibl4CV/7I1tz5eQz8lIAh41STZA3wM= Subject: Re: [PATCH 0/2] optee: fix OOM seen due to tee_shm_free() To: Allen Pais , jens.wiklander@linaro.org, zajec5@gmail.com Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org References: <20210217092714.121297-1-allen.lkml@gmail.com> From: Allen Pais Message-ID: <7ed919a9-2ef3-95f3-3bf4-70961a18656a@linux.microsoft.com> Date: Tue, 23 Feb 2021 11:47:20 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210217092714.121297-1-allen.lkml@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > The following out of memory errors are seen on kexec reboot > from the optee core. > > [ 0.368428] tee_bnxt_fw optee-clnt0: tee_shm_alloc failed > [ 0.368461] tee_bnxt_fw: probe of optee-clnt0 failed with error -22 > > tee_shm_release() is not invoked on dma shm buffer. > > Implement .shutdown() in optee core as well as bnxt firmware driver > to handle the release of the buffers correctly. > > More info: > https://github.com/OP-TEE/optee_os/issues/3637 Jens, Could you please take sometime out and review the series. Thanks. > > Allen Pais (2): > optee: fix tee out of memory failure seen during kexec reboot > firmware: tee_bnxt: implement shutdown method to handle kexec reboots > > drivers/firmware/broadcom/tee_bnxt_fw.c | 9 ++++ > drivers/tee/optee/core.c | 69 ++++++++++++++++++------- > 2 files changed, 58 insertions(+), 20 deletions(-) >