Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2159428pxb; Mon, 22 Feb 2021 23:10:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJwFqf1oQx9Et54QECxtLGN0ENGhbCDro7WOjp5RkFTCxhM7Ye2NZ/H99ZUTpmkOtKFI8yXW X-Received: by 2002:a17:906:115a:: with SMTP id i26mr19862660eja.10.1614064220135; Mon, 22 Feb 2021 23:10:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614064220; cv=none; d=google.com; s=arc-20160816; b=xWRAnNLj0jC73b2w/9lzlwCl8lsczEkJ/7E0r/Vc2mteQdAJz5mNJOnJDcr70bWJK/ EMt4v87cCOk0uD+lecVu4LDb7qEc63kJxej27xwo5TeBxScQ/FVmlNBDieZuKzeGRdNA j0n+8SC8JtSpxuVkRZ6jWJdIAkwJDrJEQQ0Cr6SacsjVAxMXCr/fFZbHPCMFWfitAFW6 QRwpapOSD8Tt21ZaOYaQk4xayZk3a4t8EVHIRdTOPTvZjpU95A7g/RvR5iQjtwobJHBo VRyZfgZtUktDdlROzV2ffFWq/37M4pfR+l/TBAscxRREnHfdYZvrZZPV1ubxvyBsrVQr 5vyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dmarc-filter:sender:dkim-signature; bh=pTEQghgVkfDvWMsdEuAjG7tlCrXlwH0AYTvKRDuVXFI=; b=Iyv17IuEhEFvj7uZPQxrPbhZq+UgE0EQicIcqbhxgFpFXJkQyCxlDrNt27qmAaACk5 bo4/lkmhPJM4Dw9bbu84axDF7TjgxQSVn7Zn2mOjIs6nvpEYFmy3pgrDyi8xkUHQGXot wqr+KcnhpQ/44JaChbO967IG0A/EIkw4qAyVlyGg86TUCGdwC3esLJJgqS7JYLQE0wE6 Ee/rfuug0alyCzqmRvCJ7BJsPafysSWYOaAc4YwWqijc+ai6a5zyX/qsCFRCObD+79wD +RwU+pOHezvHXtXARQ0HDz/My7OmAlYY5dc42ADtSgETdh8w0nqMpvUSTZhI5WeLVy1Z lMGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=BFiRfYRT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d13si1931239edp.48.2021.02.22.23.09.55; Mon, 22 Feb 2021 23:10:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=BFiRfYRT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230472AbhBWHJ2 (ORCPT + 99 others); Tue, 23 Feb 2021 02:09:28 -0500 Received: from z11.mailgun.us ([104.130.96.11]:46804 "EHLO z11.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230174AbhBWHJ1 (ORCPT ); Tue, 23 Feb 2021 02:09:27 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1614064148; h=Content-Transfer-Encoding: Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=pTEQghgVkfDvWMsdEuAjG7tlCrXlwH0AYTvKRDuVXFI=; b=BFiRfYRTfItunM0RAy39wkKz+MAORoFuN1w03buIj25JUlMl17y5S53wx9LxsdBA1PbexWZY Eiao51yUuD7Mdj8lHDej163dY8Ad4LnpSByvf2oUierREX6rjszreXNpcNwbb8J67/UhUMGk 9AS3CZnhFA92CrFnitxnzZ3HdIg= X-Mailgun-Sending-Ip: 104.130.96.11 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 6034a9f9ba086638301f0697 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 23 Feb 2021 07:08:40 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id A2487C43464; Tue, 23 Feb 2021 07:08:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 037B3C433CA; Tue, 23 Feb 2021 07:08:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 037B3C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Pkshih Cc: "chenhaoa\@uniontech.com" , "linux-kernel\@vger.kernel.org" , "tony0620emma\@gmail.com" , Timlee , "zhanjun\@uniontech.com" , "kuba\@kernel.org" , "netdev\@vger.kernel.org" , "davem\@davemloft.net" , "arnd\@arndb.de" , "linux-wireless\@vger.kernel.org" Subject: Re: [PATCH v2] rtw88: 8822ce: fix wifi disconnect after S3/S4 on HONOR laptop References: <20210222094638.18392-1-chenhaoa@uniontech.com> <87h7m4iefe.fsf@codeaurora.org> <1613993809.2331.12.camel@realtek.com> Date: Tue, 23 Feb 2021 09:08:34 +0200 In-Reply-To: <1613993809.2331.12.camel@realtek.com> (pkshih@realtek.com's message of "Mon, 22 Feb 2021 11:36:51 +0000") Message-ID: <878s7fi7m5.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pkshih writes: >> > --- a/drivers/net/wireless/realtek/rtw88/rtw8822ce.c >> > +++ b/drivers/net/wireless/realtek/rtw88/rtw8822ce.c >> > @@ -25,7 +25,6 @@ static struct pci_driver rtw_8822ce_driver =3D { >> >=C2=A0=C2=A0 .id_table =3D rtw_8822ce_id_table, >> >=C2=A0=C2=A0 .probe =3D rtw_pci_probe, >> >=C2=A0=C2=A0 .remove =3D rtw_pci_remove, >> > - .driver.pm =3D &rtw_pm_ops, >>=20 >> Why just 8822ce? Why not remove rtw_pm_ops entirely if it just creates >> problems? > > I think we can't remove rtw_pm_ops, because wowlan will not work. Ah. A comment code in the code stating that would be nice. --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes