Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2163980pxb; Mon, 22 Feb 2021 23:19:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJx9yfLroRde6/RdOQmPzzcvwSuiyZ63Ok+X/igXbYPnX5nsbTi7gIlyKIuwe5vtDXnC88N+ X-Received: by 2002:a17:907:9810:: with SMTP id ji16mr23676552ejc.394.1614064791837; Mon, 22 Feb 2021 23:19:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614064791; cv=none; d=google.com; s=arc-20160816; b=g4XhLDWojeRodGjoe8tiAVTvsg+zDZWcrUckMEfGuqp5fTiujlKwpin6AFM7DaQ4Wa zcPLOYHcv7San9oon1Fdt3Dq7rNq5y0HQ+aGeHwFce6Q/V+D19Htl/x4AhbnAr+lD/Je QkD2YO+RMv/LdH79gTKksi/yemBVXeTQeocPIOj8i0wl8iBUR7YFBRVJhgT4QYepN7JA lPLrBWpyzOeSFK8roLPi1BT/vEpxEmtGFl9keJp4PTdHB3egWoo1V1Q1JZSUOMnR8z0S N+s8cvzQWTfQzTVJBBkJqQOrgtTagAvo4kUQfa0vHvLNwF3QQQcq2iWVaHablRQuiMgW IgiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=SL8EOhfWVeZCCFbgFq2+PNYZmv5Ok4mvgdsFBHVvRZA=; b=tagSEzpWQA+5kqzootseu1wgTa5QWh5KD48rxjINpUiuPUwkHoBPQbGfASJlk4bct/ ZWUHyZbv6NjRd3r3pfo1cMglUDhCLs06mdxJfQ02wQ3EC0yOPFfZEsMYTKpQlpvHGjp+ OFfir/bFcwaDyOSefhHKJiT+WpRVeZl+wpuhqKa8ahw1HkUFbVBgnR+haa2E5VLvJgxf uIKU21DcbiudDi9dFIt/BZR8V1wYTBHdzBU+nPPjk2LiDQK8w0TXOjz99jDprLOFTBlE 0y7ZJYm5xBAdk0Cwpg8ptFEmxwjBg0GSv95fWjUFhEsRyFm5+Sm44D4+W0uF6U6ex/tF hzYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ka12si14462902ejc.323.2021.02.22.23.19.25; Mon, 22 Feb 2021 23:19:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231719AbhBWHR3 (ORCPT + 99 others); Tue, 23 Feb 2021 02:17:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231384AbhBWHRT (ORCPT ); Tue, 23 Feb 2021 02:17:19 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFDF1C06174A for ; Mon, 22 Feb 2021 23:16:38 -0800 (PST) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lERvq-0004vW-Rn; Tue, 23 Feb 2021 08:16:30 +0100 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1lERvq-0005Jg-2d; Tue, 23 Feb 2021 08:16:30 +0100 Date: Tue, 23 Feb 2021 08:16:30 +0100 From: Oleksij Rempel To: William Breathitt Gray Cc: Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pengutronix Kernel Team , David Jander , Robin van der Gracht , linux-iio@vger.kernel.org, Linus Walleij , Jonathan Cameron Subject: Re: [PATCH v6 0/2] add support for GPIO or IRQ based evemt counter Message-ID: <20210223071630.lazyuvhr4xgqhafi@pengutronix.de> References: <20210216081356.3577-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 08:08:49 up 82 days, 21:15, 39 users, load average: 0.09, 0.07, 0.01 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi William, On Mon, Feb 22, 2021 at 10:48:56AM +0900, William Breathitt Gray wrote: > On Tue, Feb 16, 2021 at 09:13:54AM +0100, Oleksij Rempel wrote: > > changes v6: > > - rename it to interrupt-counter > > Hi Oleksij, > > Sorry to nitpick again, I think "irq-counter" as Jonathan suggested in > an earlier review would be a better name afterall. Would you be able to > rename this driver to use that name instead? I would prefer not to rename it. IRQ (Interrupt Request) is a signal outside of the system. Below some frequency rate, amount of counted ISR (interrupt service routine) calls or events would be equal to the actual IRQs. If frequency is too high, we will count ISR, but not IRQs. In any case, interrupt-counter is more or leas neutral, without triggering too many wrong assumptions. Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |