Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 23 Feb 2021 07:39:05 +0100
Message-ID: <s5hh7m3wanq.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Rajesh Kumbhakar <sssraj.sssraj@gmail.com>
Cc:     perex@perex.cz, tiwai@suse.com, sfr@canb.auug.org.au,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: core: fixed coding style errors
In-Reply-To: <20210222194156.26758-1-sssraj.sssraj@gmail.com>
References: <20210222194156.26758-1-sssraj.sssraj@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 22 Feb 2021 20:41:56 +0100,
Rajesh Kumbhakar wrote:
> 
> fixing ERROR: "foo * bar" should be "foo *bar"
> fixing WARNING: Missing a blank line after declarations
> 
> Signed-off-by: Rajesh Kumbhakar <sssraj.sssraj@gmail.com>
> ---
>  sound/core/hwdep_compat.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/core/hwdep_compat.c b/sound/core/hwdep_compat.c
> index a0b76706c..d8624a14a 100644
> --- a/sound/core/hwdep_compat.c
> +++ b/sound/core/hwdep_compat.c
> @@ -36,11 +36,13 @@ enum {
>  	SNDRV_HWDEP_IOCTL_DSP_LOAD32   = _IOW('H', 0x03, struct snd_hwdep_dsp_image32)
>  };
>  
> -static long snd_hwdep_ioctl_compat(struct file * file, unsigned int cmd,
> +static long snd_hwdep_ioctl_compat(struct file *file, unsigned int cmd,
>  				   unsigned long arg)
>  {
>  	struct snd_hwdep *hw = file->private_data;
> +
>  	void __user *argp = compat_ptr(arg);

You shouldn't put a blank line here.


thanks,

Takashi