Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: RE: [PATCH v22 2/4] scsi: ufs: L2P map management for HPB read
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Avri Altman <Avri.Altman@wdc.com>,
        Daejun Park <daejun7.park@samsung.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "huobean@gmail.com" <huobean@gmail.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        JinHwan Park <jh.i.park@samsung.com>,
        SEUNGUK SHIN <seunguk.shin@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>
In-Reply-To: <DM6PR04MB657508BC3F0D0240FDCBB043FC809@DM6PR04MB6575.namprd04.prod.outlook.com>
Message-ID: <20210223080043epcms2p83f813841174ade50ef97481b3f4cdef7@epcms2p8>
Date:   Tue, 23 Feb 2021 17:00:43 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <DM6PR04MB657508BC3F0D0240FDCBB043FC809@DM6PR04MB6575.namprd04.prod.outlook.com>
        <20210222092907epcms2p307f3c4116349ebde6eed05c767287449@epcms2p3>
        <20210222093050epcms2p6506a476c777785c6212cc80fc6158714@epcms2p6>
        <CGME20210222092907epcms2p307f3c4116349ebde6eed05c767287449@epcms2p8>
Precedence: bulk

> +/*
> > + * This function will parse recommended active subregion information in
> > sense
> > + * data field of response UPIU with SAM_STAT_GOOD state.
> > + */
> > +void ufshpb_rsp_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
> > +{
> > +       struct ufshpb_lu *hpb;
> > +       struct scsi_device *sdev;
> > +       struct utp_hpb_rsp *rsp_field = &lrbp->ucd_rsp_ptr->hr;
> > +       int data_seg_len;
> > +       bool found = false;
> > +
> > +       __shost_for_each_device(sdev, hba->host) {
> > +               hpb = ufshpb_get_hpb_data(sdev);
> > +
> > +               if (!hpb)
> > +                       continue;
> > +
> > +               if (rsp_field->lun == hpb->lun) {
> > +                       found = true;
> > +                       break;
> This piece of code looks awkward, although it is probably working.
> Why not just having a reference to the hpb luns, e.g. something like:
> struct ufshpb_lu *hpb_luns[8] in struct ufs_hba.
> Less elegant - but much more effective than iterating the scsi host on every completion interrupt.

OK,

> > +               }
> > +       }
> > +
> > +       if (!found)
> > +               return;
> > +
> > +       if ((ufshpb_get_state(hpb) != HPB_PRESENT) &&
> > +           (ufshpb_get_state(hpb) != HPB_SUSPEND)) {
> > +               dev_notice(&hpb->sdev_ufs_lu->sdev_dev,
> > +                          "%s: ufshpb state is not PRESENT/SUSPEND\n",
> > +                          __func__);
> > +               return;
> > +       }
> > +
> > +       data_seg_len = be32_to_cpu(lrbp->ucd_rsp_ptr->header.dword_2)
> > +               & MASK_RSP_UPIU_DATA_SEG_LEN;
> > +
> > +       /* To flush remained rsp_list, we queue the map_work task */
> > +       if (!data_seg_len) {
> data_seg_len should be 0x14

It is checking non-HPB hint UPIU. It is used for kicking map work.

> > +               if (!ufshpb_is_general_lun(hpb->lun))
> > +                       return;
> > +
> > +               ufshpb_kick_map_work(hpb);
> > +               return;
> > +       }
> > +
> > +       /* Check HPB_UPDATE_ALERT */
> > +       if (!(lrbp->ucd_rsp_ptr->header.dword_2 &
> > +             UPIU_HEADER_DWORD(0, 2, 0, 0)))
> > +               return;
> > +
> > +       BUILD_BUG_ON(sizeof(struct utp_hpb_rsp) != UTP_HPB_RSP_SIZE);
> > +
> > +       if (!ufshpb_is_hpb_rsp_valid(hba, lrbp, rsp_field))
> > +               return;
> How about moving both the data_seg_len and alert bit checks into ufshpb_is_hpb_rsp_valid,
> And moving ufshpb_is_hpb_rsp_valid to the beginning of the function?
> This way you would save redundant stuff if not a valid response. 

I will move alert bit check into ufshpb_is_hpb_rsp_valid.

Thanks,
Daejun