Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2218080pxb; Tue, 23 Feb 2021 01:15:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJx9J/kEceUgcTdvhpC7tlLrWPRUj2+aRcq6HUhIx9nqa7OfuW00udO/YOqK82PlpFagKfEW X-Received: by 2002:aa7:c243:: with SMTP id y3mr14754243edo.122.1614071701666; Tue, 23 Feb 2021 01:15:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614071701; cv=none; d=google.com; s=arc-20160816; b=odn8kpE6pGHJUpfUqdvEnc+0GOFmBS5nc5y9Q2QL1E5oaNGgK9M4DuxLiPKjrd0joe OJ2KQhzkjtHp8lIKgcN5iFnzfO6Bqu0fNTlbE00E31EyW9Iuqe9Se5TiH0jl1HULHdqG g26wn80ABbeSoa0QigHu+ZDqtDU5MKpM3AeYBQAZtRq7+oY3UYexYo5MCiuRvLLovqFF 5DHNYyvcZHPQiI9eOiQLkZk0+MlJwIpH5MNMTAfexg8266bMyziXW47a+XQhtDi2Xwp+ csLUlSwPy9cG2Ihmz8Ve3wkm3wNcvUCW9/XP/ffWwziYHs47cGN5KFMxl52MbaST0k0C yKyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:dlp-filter:cms-type :content-transfer-encoding:date:message-id:in-reply-to:cc:to:from :sender:reply-to:subject:mime-version:dkim-signature:dkim-filter; bh=umypOIWVMuOIZl7KF8RuZGFFckDlQDeVTfujdiXuuQk=; b=VkgqhDs1lKU/UpkLaVHFkXo7WF9lseMqOpSkOro+cfRaoWHfd+72tLbZthEGBn9jef zp8ynKR2Nkw87qhnskTAxJgQjQILwePU4ufvwyaZ1BGcXC8yiMeNXZJ1KZK085wW+U7h 5MaSbNNFKrIl1Sp1tH4LBe2tvySOPfxZgJkReXcBcvNowuBXQVCL74Vwl13auEwPisFj uGGT6L5xB9czNI5eXrgFJROb/68GsTxNOG2i/3lWiLrOcO1MK2+Whqau4u7uo2tCw0hf kr0hmXnpAiiyuHMCEsYXXHSohWz6DeofMb4zn2XCx6iTkY+7LcT9wjjpCWQo9nJanqxl UTWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=Cm2dCCBk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a12si14084658edn.568.2021.02.23.01.14.37; Tue, 23 Feb 2021 01:15:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=Cm2dCCBk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231976AbhBWIDs (ORCPT + 99 others); Tue, 23 Feb 2021 03:03:48 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:60816 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232098AbhBWIDR (ORCPT ); Tue, 23 Feb 2021 03:03:17 -0500 Received: from epcas2p4.samsung.com (unknown [182.195.41.56]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20210223080235epoutp035d54a8965847dd4673b9cf8236bf7f2f~mUbVDBvP12764727647epoutp03K for ; Tue, 23 Feb 2021 08:02:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20210223080235epoutp035d54a8965847dd4673b9cf8236bf7f2f~mUbVDBvP12764727647epoutp03K DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1614067355; bh=umypOIWVMuOIZl7KF8RuZGFFckDlQDeVTfujdiXuuQk=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=Cm2dCCBk4P5Vd9YUeUSBrO1oiMhqOhYdHk1vQwDrMsnK3F+VVhK/gYdHzFhXQje5i YMIOYpCZqZN7uOZq9HIHnSIkP+yJMIzGczobQtf0US5hVxEgVElGoNkoXruyZsdJuX GSD6rXq2zypG7mfhwi+bB5eVjs1ApX7gTUZrRsfA= Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas2p2.samsung.com (KnoxPortal) with ESMTP id 20210223080234epcas2p202faa34bc713d851da78d66a6bfd6ff3~mUbUUq_wf0970109701epcas2p2D; Tue, 23 Feb 2021 08:02:34 +0000 (GMT) Received: from epsmges2p3.samsung.com (unknown [182.195.40.187]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4DlBNn1y0dz4x9Ps; Tue, 23 Feb 2021 08:02:33 +0000 (GMT) X-AuditID: b6c32a47-b81ff7000000148e-87-6034b699aaa8 Received: from epcas2p1.samsung.com ( [182.195.41.53]) by epsmges2p3.samsung.com (Symantec Messaging Gateway) with SMTP id CB.F1.05262.996B4306; Tue, 23 Feb 2021 17:02:33 +0900 (KST) Mime-Version: 1.0 Subject: RE: Re: [PATCH v22 4/4] scsi: ufs: Add HPB 2.0 support Reply-To: daejun7.park@samsung.com Sender: Daejun Park From: Daejun Park To: Bean Huo , Daejun Park , Greg KH , "avri.altman@wdc.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "asutoshd@codeaurora.org" , "stanley.chu@mediatek.com" , "cang@codeaurora.org" , "bvanassche@acm.org" , ALIM AKHTAR , Javier Gonzalez CC: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , JinHwan Park , SEUNGUK SHIN , Sung-Jun Park , yongmyung lee , Jinyoung CHOI , BoRam Shin X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <62be9fcfbd79b5977b34de85e486409ec74b7359.camel@gmail.com> X-CPGS-Detection: blocking_info_exchange X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20210223080232epcms2p6f75e3537fc8c0457c0904a4e5f8c1cd8@epcms2p6> Date: Tue, 23 Feb 2021 17:02:32 +0900 X-CMS-MailID: 20210223080232epcms2p6f75e3537fc8c0457c0904a4e5f8c1cd8 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL X-CPGSPASS: Y X-CPGSPASS: Y CMS-TYPE: 102P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCJsWRmVeSWpSXmKPExsWy7bCmqe7MbSYJBnsfcFk8mLeNzWJv2wl2 i5c/r7JZHL79jt1i2oefzBaf1i9jtXh5SNNi1YNwi+bF69ks5pxtYLLo7d/KZvH4zmd2i0U3 tjFZ9P9rZ7G4vGsOm0X39R1sFsuP/2OyuL2Fy2Lp1puMFp3T17BYLFq4m8VB1OPyFW+Py329 TB47Z91l95iw6ACjx/65a9g9Wk7uZ/H4+PQWi0ffllWMHp83yXm0H+hmCuCKyrHJSE1MSS1S SM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xNtVVy8QnQdcvMAfpQSaEsMacUKBSQWFys pG9nU5RfWpKqkJFfXGKrlFqQklNgaFigV5yYW1yal66XnJ9rZWhgYGQKVJmQk3F993bmgjlM FUuvrWdtYLzO2MXIySEhYCLxc+pMti5GLg4hgR2MEl+6+lm6GDk4eAUEJf7uEAapERawl3hx 4ho7iC0koCSx/uIsdoi4nsSth2vA5rAJ6EhMP3GfHWSOiMBSFokpx5cxgzjMAr+YJE48/gC1 jVdiRvtTFghbWmL78q1gcU4Bd4m3j08zQ8Q1JH4s64WyRSVurn7LDmO/PzYfao6IROu9s1A1 ghIPfu6GiktKHNv9gQnCrpfYeucXI8gREgI9jBKHd95ihUjoS1zr2Ah2BK+Ar8S+a/fBmlkE VCUmfemEWuYiMbWtD6yeWUBeYvvbOcygUGEW0JRYv0sfxJQQUJY4cosF5q2Gjb/Z0dnMAnwS HYf/wsV3zHsCdZqaxLqf65kmMCrPQgT1LCS7ZiHsWsDIvIpRLLWgODc9tdiowBg5djcxgpO7 lvsOxhlvP+gdYmTiYDzEKMHBrCTCy3bXKEGINyWxsiq1KD++qDQntfgQoynQlxOZpUST84H5 Ja8k3tDUyMzMwNLUwtTMyEJJnLfY4EG8kEB6YklqdmpqQWoRTB8TB6dUA9Mi2eZNh9f0ulxO 1ZHNstAL5li3SahAjv/mrDOPfi8zcxEVue1kr1F3Lpr56Mcnqz/vseOY9+NrceVMnvfbJyxk +TFtxRSXlPiHNn+2Z96U/iK5gMutyNg2rXKibtSbzN4dyQb5G04LFhoy6eve2HzD0/On1vGO mgexcTrTinnfWDNs/LThzVTHs+3TVh1XdlseHVv+b6Xz5icnA1Ij21+9P7p7i9y7gOcaXxnv bFwaYlBiWyPJY/Spm/Pu5ykG0pccFuXW7C6Y+LWTqzC9Q036m+mj+F3XP2x+r33opxZ3zdPs +eUzfAWcQ07Gmc//wZXEdo1D68zy0h8Hc5NUDmvrirlWb7rkf8vj8JfXLt1KLMUZiYZazEXF iQBt7JbvdwQAAA== DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20210222092907epcms2p307f3c4116349ebde6eed05c767287449 References: <62be9fcfbd79b5977b34de85e486409ec74b7359.camel@gmail.com> <20210222092957epcms2p728b0c563f3cfbecbf8692d7e86f9afed@epcms2p7> <20210222092907epcms2p307f3c4116349ebde6eed05c767287449@epcms2p3> <20210222093150epcms2p155352e2255e6bfd8f8d71c737ed05e76@epcms2p1> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > +} > > +static DEVICE_ATTR_RW(requeue_timeout_ms); > > + > > +static struct attribute *hpb_dev_param_attrs[] = { > > + &dev_attr_requeue_timeout_ms.attr, > > +}; > > here, you lost a NULL member at the end of attribute struct. > OK, I will. Thanks, Daejun