Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: RE: RE: [PATCH v22 2/4] scsi: ufs: L2P map management for HPB
 read
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Daejun Park <daejun7.park@samsung.com>,
        Avri Altman <Avri.Altman@wdc.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "huobean@gmail.com" <huobean@gmail.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        JinHwan Park <jh.i.park@samsung.com>,
        SEUNGUK SHIN <seunguk.shin@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>
In-Reply-To: <20210223080043epcms2p83f813841174ade50ef97481b3f4cdef7@epcms2p8>
Message-ID: <20210223083136epcms2p89ada047f0da1fb700ace8b4e3e396697@epcms2p8>
Date:   Tue, 23 Feb 2021 17:31:36 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <20210223080043epcms2p83f813841174ade50ef97481b3f4cdef7@epcms2p8>
        <DM6PR04MB657508BC3F0D0240FDCBB043FC809@DM6PR04MB6575.namprd04.prod.outlook.com>
        <20210222092907epcms2p307f3c4116349ebde6eed05c767287449@epcms2p3>
        <20210222093050epcms2p6506a476c777785c6212cc80fc6158714@epcms2p6>
        <CGME20210222092907epcms2p307f3c4116349ebde6eed05c767287449@epcms2p8>
Precedence: bulk

>=C2=A0+/*=0D=0A>=C2=A0>=C2=A0+=C2=A0*=C2=A0This=C2=A0function=C2=A0will=C2=
=A0parse=C2=A0recommended=C2=A0active=C2=A0subregion=C2=A0information=C2=A0=
in=0D=0A>=C2=A0>=C2=A0sense=0D=0A>=C2=A0>=C2=A0+=C2=A0*=C2=A0data=C2=A0fiel=
d=C2=A0of=C2=A0response=C2=A0UPIU=C2=A0with=C2=A0SAM_STAT_GOOD=C2=A0state.=
=0D=0A>=C2=A0>=C2=A0+=C2=A0*/=0D=0A>=C2=A0>=C2=A0+void=C2=A0ufshpb_rsp_upiu=
(struct=C2=A0ufs_hba=C2=A0*hba,=C2=A0struct=C2=A0ufshcd_lrb=C2=A0*lrbp)=0D=
=0A>=C2=A0>=C2=A0+=7B=0D=0A>=C2=A0>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0struct=C2=A0ufshpb_lu=C2=A0*hpb;=0D=0A>=C2=A0>=C2=A0+=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct=C2=A0scsi_device=C2=A0*sdev;=0D=0A>=C2=
=A0>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct=C2=A0utp_hpb_rs=
p=C2=A0*rsp_field=C2=A0=3D=C2=A0&lrbp->ucd_rsp_ptr->hr;=0D=0A>=C2=A0>=C2=A0=
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0int=C2=A0data_seg_len;=0D=0A>=C2=
=A0>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0bool=C2=A0found=C2=A0=
=3D=C2=A0false;=0D=0A>=C2=A0>=C2=A0+=0D=0A>=C2=A0>=C2=A0+=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0__shost_for_each_device(sdev,=C2=A0hba->host)=C2=A0=
=7B=0D=0A>=C2=A0>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0hpb=C2=A0=3D=C2=A0ufshpb_get_hpb_dat=
a(sdev);=0D=0A>=C2=A0>=C2=A0+=0D=0A>=C2=A0>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if=C2=A0(=
=21hpb)=0D=0A>=C2=A0>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0continue;=0D=0A>=C2=A0>=C2=A0+=0D=0A>=C2=A0>=C2=A0+=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0if=C2=A0(rsp_field->lun=C2=A0=3D=3D=C2=A0hpb->lun)=C2=A0=7B=0D=0A>=
=C2=A0>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0found=C2=A0=3D=C2=A0true;=0D=0A>=C2=A0>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0break;=0D=0A>=C2=A0This=C2=A0piece=
=C2=A0of=C2=A0code=C2=A0looks=C2=A0awkward,=C2=A0although=C2=A0it=C2=A0is=
=C2=A0probably=C2=A0working.=0D=0A>=C2=A0Why=C2=A0not=C2=A0just=C2=A0having=
=C2=A0a=C2=A0reference=C2=A0to=C2=A0the=C2=A0hpb=C2=A0luns,=C2=A0e.g.=C2=A0=
something=C2=A0like:=0D=0A>=C2=A0struct=C2=A0ufshpb_lu=C2=A0*hpb_luns=5B8=
=5D=C2=A0in=C2=A0struct=C2=A0ufs_hba.=0D=0A>=C2=A0Less=C2=A0elegant=C2=A0-=
=C2=A0but=C2=A0much=C2=A0more=C2=A0effective=C2=A0than=C2=A0iterating=C2=A0=
the=C2=A0scsi=C2=A0host=C2=A0on=C2=A0every=C2=A0completion=C2=A0interrupt.=
=0D=0A=0D=0AHow=20about=20checking=20(cmd->lun=20=3D=3D=20rsp->lun)=20befor=
e=20the=20iteration?=0D=0AMajor=20case=20will=20be=20have=20same=20lun.=20A=
nd,=20it=20is=20hard=20to=20add=20struct=20ufshpb_lu=20*hpb_luns=5B128=5D=
=0D=0Ain=20struct=20ufs_hba,=20because=20LUN=20can=20be=20upto=20127.=0D=0A=
=0D=0AThanks,=0D=0ADaejun