Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH 1/2] leds: bcm6328: improve write and read functions
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <20210223083449.GA9750@amd>
Date:   Tue, 23 Feb 2021 09:42:21 +0100
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Dan Murphy <dmurphy@ti.com>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <3826ACDE-EFF2-4CC5-82EE-2DBC991CF996@gmail.com>
References: <20210223081732.9362-1-noltari@gmail.com>
 <20210223081732.9362-2-noltari@gmail.com> <20210223083449.GA9750@amd>
To:     Pavel Machek <pavel@ucw.cz>
Precedence: bulk

Hi Pavel,

> El 23 feb 2021, a las 9:34, Pavel Machek <pavel@ucw.cz> escribi=C3=B3:
>=20
> On Tue 2021-02-23 09:17:31, =C3=81lvaro Fern=C3=A1ndez Rojas wrote:
>> This is proven to work in BMIPS BE/LE and ARM BE/LE, as used in =
bcm2835-rng
>> and bcmgenet drivers.
>> Both should also be inline functions.
>=20
>=20
>=20
>> -#ifdef CONFIG_CPU_BIG_ENDIAN
>> -	iowrite32be(data, reg);
>> -#else
>> -	writel(data, reg);
>> -#endif
>> +	/* MIPS chips strapped for BE will automagically configure the
>> +	 * peripheral registers for CPU-native byte order.
>> +	 */
>=20
> Bad comment style.

I just wanted to copy the same comment as the one in bcm2835-rng and =
bcmgenet=E2=80=A6
=
https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef1=
00731/drivers/char/hw_random/bcm2835-rng.c#L42-L60
=
https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef1=
00731/drivers/net/ethernet/broadcom/genet/bcmgenet.c#L71-L88

>=20
>> +	if (IS_ENABLED(CONFIG_MIPS) && =
IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
>> +		__raw_writel(data, reg);
>> +	else
>> +		writel_relaxed(data, reg);
>> }
>=20
> Code does not match comment (still need to do conversion on
> non-MIPS?), and it certainly should not be here (do all mipsen behave
> like that?!), and it really should not be converting to _relaxed at
> the same time.

I think it's because non-MIPS BE exposes that as little endian, but =
Florian can probably help us with that=E2=80=A6

>=20
> Best regards,
> 								Pavel
> --=20
> http://www.livejournal.com/~pavelmachek

Best regards,
=C3=81lvaro.=