Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <d5393d50a2d7c4752828a5707a6225ff6ca62f68.camel@gmail.com>
Subject: Re: [PATCH v22 4/4] scsi: ufs: Add HPB 2.0 support
From:   Bean Huo <huobean@gmail.com>
To:     daejun7.park@samsung.com, Greg KH <gregkh@linuxfoundation.org>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>
Cc:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        JinHwan Park <jh.i.park@samsung.com>,
        SEUNGUK SHIN <seunguk.shin@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>
Date:   Tue, 23 Feb 2021 10:25:47 +0100
In-Reply-To: <20210222093150epcms2p155352e2255e6bfd8f8d71c737ed05e76@epcms2p1>
References: <20210222092957epcms2p728b0c563f3cfbecbf8692d7e86f9afed@epcms2p7>
         <20210222092907epcms2p307f3c4116349ebde6eed05c767287449@epcms2p3>
         <CGME20210222092907epcms2p307f3c4116349ebde6eed05c767287449@epcms2p1>
         <20210222093150epcms2p155352e2255e6bfd8f8d71c737ed05e76@epcms2p1>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2021-02-22 at 18:31 +0900, Daejun Park wrote:
>                 }
>         }
> @@ -532,8 +870,8 @@ static int ufshpb_execute_map_req(struct
> ufshpb_lu *hpb,
>         if (unlikely(last))
>                 mem_size = hpb->last_srgn_entries * HPB_ENTRY_SIZE;
>  
> -       ufshpb_set_read_buf_cmd(rq->cmd, map_req->rgn_idx,
> -                               map_req->srgn_idx, mem_size);
> +       ufshpb_set_read_buf_cmd(rq->cmd, map_req->rb.rgn_idx,
> +                               map_req->rb.srgn_idx, hpb-
> >srgn_mem_size);

Are you sure here it is hpb->srgn_mem_size, not mem_size???
if not mem_size, why you kept mem_size??

Bean