Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH 1/2] leds: bcm6328: improve write and read functions
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <20210223085819.GB9750@amd>
Date:   Tue, 23 Feb 2021 10:05:00 +0100
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Dan Murphy <dmurphy@ti.com>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <F349F1C2-4D4F-4BF7-9ADC-6E879197405B@gmail.com>
References: <20210223081732.9362-1-noltari@gmail.com>
 <20210223081732.9362-2-noltari@gmail.com> <20210223083449.GA9750@amd>
 <3826ACDE-EFF2-4CC5-82EE-2DBC991CF996@gmail.com> <20210223085819.GB9750@amd>
To:     Pavel Machek <pavel@ucw.cz>
Precedence: bulk


> El 23 feb 2021, a las 9:58, Pavel Machek <pavel@ucw.cz> escribi=C3=B3:
>=20
> Hi!
>=20
>>>> This is proven to work in BMIPS BE/LE and ARM BE/LE, as used in =
bcm2835-rng
>>>> and bcmgenet drivers.
>>>> Both should also be inline functions.
>>>=20
>>>=20
>>>=20
>>>> -#ifdef CONFIG_CPU_BIG_ENDIAN
>>>> -	iowrite32be(data, reg);
>>>> -#else
>>>> -	writel(data, reg);
>>>> -#endif
>>>> +	/* MIPS chips strapped for BE will automagically configure the
>>>> +	 * peripheral registers for CPU-native byte order.
>>>> +	 */
>>>=20
>>> Bad comment style.
>>=20
>> I just wanted to copy the same comment as the one in bcm2835-rng and =
bcmgenet=E2=80=A6
>> =
https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef1=
00731/drivers/char/hw_random/bcm2835-rng.c#L42-L60
>> =
https://github.com/torvalds/linux/blob/3b9cdafb5358eb9f3790de2f728f765fef1=
00731/drivers/net/ethernet/broadcom/genet/bcmgenet.c#L71-L88
>>=20
>=20
> Yeah, but ideally you should not be copying comments; there should be
> one central place which does it and does it right.

I=E2=80=99m open to suggestions :).
Which central place would be a good place for you?

>=20
> 								Pavel
>=20
> --=20
> http://www.livejournal.com/~pavelmachek