Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH] irqchip/bcm-6345-l1: fix SMP support
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <6169cb21-538b-1066-51cb-dd362f811fa1@gmail.com>
Date:   Tue, 23 Feb 2021 13:30:06 +0100
Cc:     Jonas Gorski <jonas.gorski@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Marc Zyngier <maz@kernel.org>,
        bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <B78512C9-E73F-45E2-B7D8-C184D9A273A0@gmail.com>
References: <20210222201332.30253-1-noltari@gmail.com>
 <6169cb21-538b-1066-51cb-dd362f811fa1@gmail.com>
To:     Florian Fainelli <f.fainelli@gmail.com>
Precedence: bulk

Hi Florian,

Yes, you=E2=80=99re right, there seems to be a bug, because =
cpu_number_map() and cpu_logical_map() are returning the same when =
BCM6358 starts with CMT 1:
[    4.662896] bcm6345_l1_irq_handle: smp_id=3D0 cpu_logical=3D1 =
cpu_number=3D1

Let=E2=80=99s see if I can fix it=E2=80=A6

Best regards,
=C3=81lvaro.

> El 22 feb 2021, a las 22:00, Florian Fainelli <f.fainelli@gmail.com> =
escribi=C3=B3:
>=20
>=20
>=20
> On 2/22/2021 12:13 PM, =C3=81lvaro Fern=C3=A1ndez Rojas wrote:
>> Some BCM6358 devices start with Core #1 instead of Core #0.
>> Apart from that, SMP is restricted to 1 CPU since BCM6358 has a =
shared TLB,
>> which makes it impossible for the current SMP support to start both =
CPUs.
>>=20
>> The problem is that smp_processor_id() returns 0 and then =
cpu_logical_map()
>> converts that to 1, which accesses an uninitialized position of =
intc->cpus[],
>> resulting in a kernel panic.
>=20
> Sounds like you nee to correct the way the cpu_logical_map[] is
> populated then?
> --=20
> Florian