Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2403988pxb; Tue, 23 Feb 2021 06:24:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwBX+gZCEr71d2wxf/ifXKRGqJwyrOes1RFTY4H5dTyW8sUPiv5U0T1BJU7YCu7edvhWSIg X-Received: by 2002:aa7:c243:: with SMTP id y3mr16116363edo.122.1614090252442; Tue, 23 Feb 2021 06:24:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614090252; cv=none; d=google.com; s=arc-20160816; b=ieX84L7V793R0HOsfHs3Ih9Y7bb+rSbjKjFn1v4+/2Up4Gb/vweBjYFbhi/fxTkk23 dmMeyFOwraSwic6kuzIaK4jPPl/RuFQujhp3nfSNquWUasi0xgLPWGdp1XLkUFXJcu1o ai5lsGFjhKvVuJ5jBX+hAcvJm2NQByP+IZSwGrGdO4BQoRciQa3qnsQG3T7nDarYpIXV 9pbezlMHjMln868oR5Sqve4uXjvd68N3U3N/MDBG/cUGaIJXJ1L/fP3gZzjpsWKbLlEP 8PvGtFNUawyX6fxpA3fqRs2gfL56pls3a1cHlQ8GzKdw21UNVRh8e+6rGC/4thheiMrk oYnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=x3DW69ELSoGab9iFk3XQpMfjw5ZB9SvGphEN2R3aLT0=; b=RpWIk76hgdwcOfqyaHIAbYqFzpew7OQJ01WbxfMZzEmSDXrt2hgJ3v5PwUepetuUZS XFgnBcBuGe6k8lZrfBVY3OUpODDWHDCsK2Op1kMW/JXc5b30zLmiZ2JKypE3pjTmWOLh u7X0Ig/WTwJFhlQc8KBnOZhctOG3n/AxGvTpcvSWz/Aorq35l+1snJ5p4hp0IKLyLsJw 5L0uBTcRnZ13iSoNiueJQ42wkMZqf6teRU/8g3ibIzaB+uzl4bSsok24Sw2NqlwAOQEz RHZXYtWO4xfl/B24CmN8a1mkOCZ7Os2Kd1vT1yhhp79rLMhPMJjShBnFP4pRduG8Vn4m Gffw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iEi49+GE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a12si14614124edn.568.2021.02.23.06.23.47; Tue, 23 Feb 2021 06:24:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iEi49+GE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232606AbhBWMe4 (ORCPT + 99 others); Tue, 23 Feb 2021 07:34:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:35719 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232673AbhBWMe2 (ORCPT ); Tue, 23 Feb 2021 07:34:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614083576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x3DW69ELSoGab9iFk3XQpMfjw5ZB9SvGphEN2R3aLT0=; b=iEi49+GEl0jT5xDnT3Bkd5YLhlhA1r8nyRkPiiPbIQtzvMtbxyyNaG4lAHUvIv2yGuDneo TqQxyeqdlUTJjvIwAcxGeyznCF9zljeLYvL4abueYvbb9tGWkRs9Cc4uSXXbf+q/VvVFJG 3KcQ2zztVYi4m7MSJjyPT3q4LVpjMtg= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-466-a3UbpaE0P4ipXZBWa_o7ug-1; Tue, 23 Feb 2021 07:32:53 -0500 X-MC-Unique: a3UbpaE0P4ipXZBWa_o7ug-1 Received: by mail-wm1-f71.google.com with SMTP id k18so618056wmi.6 for ; Tue, 23 Feb 2021 04:32:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=x3DW69ELSoGab9iFk3XQpMfjw5ZB9SvGphEN2R3aLT0=; b=kVAgRTMfe8RFfxZYvLBHjiP8YSD96Jcmeu/gqHwAsuj8z622TNJTF2xJlMo4/QOki4 35k5/6/lISIUT7+DiAdr69h+SShjiEf2rDwkU8bqILTELLYQSb5B+foFbjw4YKzoeJgq Pwbp6PNnDeDwlgyFsKGXnfO6ZIKQiBa6UArj1CKc4B52huverV2pJmA680aNHfmzCWWF w66iXfpqoeAr0H50o60hEQJ6Owyr4gpkIPn/tDRr1yPMdJbvlySNs2C7sB8KxOQZn3Vx m8U++VaY1QKxGbjdWV9IW8EcF16FHbGgDICadNYtcBQ+/Vwo3/zQv0AiR0V9GJZR4Lsp F7pw== X-Gm-Message-State: AOAM532qE4LuOcYz750fFOC/Apb+wWILbVDWOgxLD3ZnGJ3nQvi0xoQ1 atHIoWNjaocwWFYbmRJ6sHt1ezeHN6E4eNzAydIJKFx41shLd+RRUOFqpA2gclnowbUuuH2LMdv HDF1QMe6LWOEwG5qeKg6DUYDU X-Received: by 2002:a1c:f60b:: with SMTP id w11mr24660187wmc.3.1614083572529; Tue, 23 Feb 2021 04:32:52 -0800 (PST) X-Received: by 2002:a1c:f60b:: with SMTP id w11mr24660173wmc.3.1614083572413; Tue, 23 Feb 2021 04:32:52 -0800 (PST) Received: from redhat.com (bzq-79-180-2-31.red.bezeqint.net. [79.180.2.31]) by smtp.gmail.com with ESMTPSA id v5sm2671407wmh.2.2021.02.23.04.32.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 04:32:52 -0800 (PST) Date: Tue, 23 Feb 2021 07:32:49 -0500 From: "Michael S. Tsirkin" To: Eli Cohen Cc: jasowang@redhat.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, si-wei.liu@oracle.com Subject: Re: [PATCH] vdpa/mlx5: Extract correct pointer from driver data Message-ID: <20210223073225-mutt-send-email-mst@kernel.org> References: <20210216055022.25248-1-elic@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210216055022.25248-1-elic@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 16, 2021 at 07:50:21AM +0200, Eli Cohen wrote: > struct mlx5_vdpa_net pointer was stored in drvdata. Extract it as well > in mlx5v_remove(). > > Fixes: 74c9729dd892 ("vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus") > Signed-off-by: Eli Cohen Sorry which tree this is for? Couldn't apply. > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c > index 6b0a42183622..4103d3b64a2a 100644 > --- a/drivers/vdpa/mlx5/net/mlx5_vnet.c > +++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c > @@ -2036,9 +2036,9 @@ static int mlx5v_probe(struct auxiliary_device *adev, > > static void mlx5v_remove(struct auxiliary_device *adev) > { > - struct mlx5_vdpa_dev *mvdev = dev_get_drvdata(&adev->dev); > + struct mlx5_vdpa_net *ndev = dev_get_drvdata(&adev->dev); > > - vdpa_unregister_device(&mvdev->vdev); > + vdpa_unregister_device(&ndev->mvdev.vdev); > } > > static const struct auxiliary_device_id mlx5v_id_table[] = { > -- > 2.29.2