Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2432898pxb; Tue, 23 Feb 2021 07:02:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJyAhuhVmwnEseVi/bjVEEi3Z6zkbqHJYT4iM6RWANnBoQa+10UFlvpkW9j4N0JcpaNdrm5L X-Received: by 2002:a05:6402:3074:: with SMTP id bs20mr18610879edb.120.1614092520621; Tue, 23 Feb 2021 07:02:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614092520; cv=none; d=google.com; s=arc-20160816; b=QQJcuX6P7XTCAMSLTgmuAIgCH/8EzUKl4pilgQdUFUtGQtikPXwj+4k14Dvv4NkGW0 4m/tK6JdzRLl5E+fEwp0WU7zlxK403GiuVD82ULdxEvv5693EGHiE3Fxphg+kOQSfpHu p97OOC/WKo9gfq6P+tZoCdG/IeeRE3bPOMEk/Vb+W7EJqWRXA5Ga3Zog5vDPyyPEibPS I+0zp78QcgngqmSjlXDNzqLjQpFPVVZIi+HkiSsCJx8pyEaqnRwx+wTiSz+Vr8YZQ3kG 8szjOpFbu4clDq+d9yF62ak3vpfwoRk3ROtXtBud3xdA2n8Ep7vvtZIb7q5n1Ic/A+g4 4yqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:in-reply-to :date:cc:to:from:subject:message-id; bh=Ue130Y7ixNRU3oUpWSphUeOq5IAty+yfKDZVeZ5VzHA=; b=INP1QYNQlmpuujHi9dAh8+vBeGCbh/XpAAFx8Qv0gxtKMBRxx1OvxhQanq/yPqC3Kh 1/usbJ24ZgDFPDNemWolhLPqEL9rr2A8byGRSkxZpjdNh+YJLni5/mq6tBrkfHzvNNny 6UUpypqPMfr0GFzrTmvwxVK16x8tvql0ub6QF/mm8tdrGyYcA66/y1GOvS6AMicHyYYF HXjZHFyIW2xD/Hg2lsB5wu8e8nATyfMuVP8/MUG+0oWmWB/SqN+NSEgvY/KsKWYLE3HL SxPUOusp4c9Ixm2y1k0Rcz7V8+c4ZK8O4IVJIEeb/3tTn/25DkZDdxISxLWrrW9rMpR3 /W9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d17si2954064edp.404.2021.02.23.07.01.35; Tue, 23 Feb 2021 07:02:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231410AbhBWO4M (ORCPT + 99 others); Tue, 23 Feb 2021 09:56:12 -0500 Received: from mx2.suse.de ([195.135.220.15]:33382 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231970AbhBWO4L (ORCPT ); Tue, 23 Feb 2021 09:56:11 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0F6D1AFCE; Tue, 23 Feb 2021 14:55:30 +0000 (UTC) Message-ID: <2fff7c82d983baccb91c4a1c0891a9b6cdc50dd6.camel@suse.de> Subject: Re: [PATCH -next] nvmem: Fix return value check in rmem_read() From: Nicolas Saenz Julienne To: Wei Yongjun , Hulk Robot , Srinivas Kandagatla Cc: linux-kernel@vger.kernel.org Date: Tue, 23 Feb 2021 15:55:29 +0100 In-Reply-To: <20210223142214.3405217-1-weiyongjun1@huawei.com> References: <20210223142214.3405217-1-weiyongjun1@huawei.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-+ZOTHRWo0mdmPr2PAEim" User-Agent: Evolution 3.38.4 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-+ZOTHRWo0mdmPr2PAEim Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2021-02-23 at 14:22 +0000, Wei Yongjun wrote: > In case of error, the function memremap() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check > should be replaced with NULL test. >=20 > Fixes: 5a3fa75a4d9c ("nvmem: Add driver to expose reserved memory as nvme= m") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- Acked-by: Nicolas Saenz Julienne Thanks! --=-+ZOTHRWo0mdmPr2PAEim Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAmA1F2EACgkQlfZmHno8 x/5q2QgAntr7DrAtYlhZ2GumimEwN+L4edjp9P+ocKfuMbUP+RhvDb/ha1RpI6JB IvbVD/GkhL7KmyQ8MWBk7tQ1uTSgl7VggqGcXQvkmKVHW2OEwa+NpGNAQDxJUajw YAG99GooA3aQxSY3FN9vvbb0xiFNZyufgIORGj7VovkrQSP49EQlgfxs5paU/leA YieP200H0k//7o/9Twl+x3BWNeurfxKyDGLuMzsHPXPxKYVdTxgCKaC/Z8FknwwY HFYy2Bmm4VAVXY2zcPXB5cSYdjU/rFWChXBhV9X4h2Y51o70paB5kx3Djv+KoJeF 97fxxJO19HGmLpT9UgqMR5vFYMEFnA== =RjAZ -----END PGP SIGNATURE----- --=-+ZOTHRWo0mdmPr2PAEim--