Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2490153pxb; Tue, 23 Feb 2021 08:15:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJyaZQrtNKAknvAq7Es0vyR/JHae7zU1iq3iPQYi2RqQYkaCsEm3dvZR8sZ/fMsUK7XG9Gfw X-Received: by 2002:aa7:dccd:: with SMTP id w13mr2870518edu.170.1614096921547; Tue, 23 Feb 2021 08:15:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614096921; cv=none; d=google.com; s=arc-20160816; b=nmQzldjVnslotWqLNRyqxHB2Edx7EZRSPQivelLzwmBt2/9li/mHtbFITAby97eHZu 69tFGUq+SoJDXxDfVoV1VKqFzIrUOhvGW/4YvckcmkT915MvZvavIs5ms9vIjav6P4+y Ck/x4UQVNgwTaZoyCBFDe7luxQxjNbt/iI5/qVAuNuwL+Hi636kcP44Z++NIQYvLtT87 6zXM0FCVuKm9pXwkvrQ0DLCPz1BOW81HqyVvfN9QT94m2Pz5M3Nj6EOOuax3E3DTy6q1 VUARBp7GXZsMMq/T+Zj+0tqxYYNSmwOuk5sMA7t4DVmxGxgRMlpogqZ6gtnrr1kgbprz uuXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=LupjWLkRUOq+CiPsIGPEup0J7yFrkHdOXthev84cAN8=; b=KpZWasXspRWx7Ijk/mkyDyT6abKxB/OePwz1qyJYyWIsibgy8sP7sOp3sH0rjtoM+4 1i1ta3Rat/qw/akWtTDWWIUlMtI/s8CVVcuPyuTxO9baRyCCq8NRXofOKh6uVoBxz1mr +6AuZUk7ozVl0erQqF/kdWF1uswz77rNZhXoDl+pVDHBWk29ero3LI97arfWRpK7EY8B lzKjQJyAYVGO8QJGSUqmxYjAl/P8ellvWytl67scc/QtNIhwTYv79ARDJz4oBCG8HHt6 8pOG7r8RyTYsPGs8/EkDujVYfZgKXQVQwl2sU1t+Q818yOIoZKLwadHLSJeOrDbQpifs YVKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="msrwyp8/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y16si14377558edi.542.2021.02.23.08.14.56; Tue, 23 Feb 2021 08:15:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="msrwyp8/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233490AbhBWQMX (ORCPT + 99 others); Tue, 23 Feb 2021 11:12:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232465AbhBWQMW (ORCPT ); Tue, 23 Feb 2021 11:12:22 -0500 Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3761DC06174A; Tue, 23 Feb 2021 08:11:40 -0800 (PST) Received: by mail-pf1-x429.google.com with SMTP id x129so4337567pfx.7; Tue, 23 Feb 2021 08:11:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LupjWLkRUOq+CiPsIGPEup0J7yFrkHdOXthev84cAN8=; b=msrwyp8/10qWFaWV+seEtedLa6l55XeaIG7sHc3PceJpDJQ3ujkK+1g2IrJ3ttipSq SbjNQpm1naE41eNLkJZ62Rvb8PyJeS1n92eiqSLVOTvLynGkqUlXV0YsI8VBJqTPV6Kk aTT14B+00rLsZC0dOZCA2KBp1TuVnCVz9pPAvu0ot8qr25mLzAr67u4f7XJxVFLPILCD 8QyWcFJVU59oSiyi7zlfiBz+3N7gCxvyaQLZVP5IIBsn+cVgQkJT0u9MwHLU0p/ctP/E ssrHQwat8k6JAT0AT4FIoU3HINErHBR7e3en2AlzQ6iyayAFGLpIVmE8UjAAZVOcrDl3 BiFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LupjWLkRUOq+CiPsIGPEup0J7yFrkHdOXthev84cAN8=; b=rxjaZzwdNIzMlDeMBW7x4sKZcM2faYB8Fo/ojdVY6axyRtAs4T0xuO4uDjyQKpr0e2 2Cdbx/8QeBb9oD+VnrSebTt61C2iME3ngk98Fgk5wCqdbNNh9C7zfjLSFv7uc+WFKJxV RmTx+J4Yw/e9qklkXA72HNrASidcfXcOA6Nfi0giv1FcLhPyFGoJ959UbWmTUk85C6XB JgBM7D9uK92dCYddTSXRrOZsQkpBekKKOjrNysfA66GkkxMj69yT4pDWmSx6PXxHLKNm YgunUD0x/AvJuJ1Eu2gLlzM3bRyHQgdJlqrytEzak5/ggBPY+kOtuV1Kl4YeODNSLBba /VDA== X-Gm-Message-State: AOAM532mdGSoYH8u3p3w4Ggg/oV7DVnSZh1SwSP0GPVqdGtCzRqhJj/a B1ibiiEzGoRzlvE8k9d3yOE= X-Received: by 2002:a62:ae18:0:b029:1ed:ac95:d8cb with SMTP id q24-20020a62ae180000b02901edac95d8cbmr9539294pff.69.1614096699775; Tue, 23 Feb 2021 08:11:39 -0800 (PST) Received: from hoboy.vegasvil.org (c-73-241-114-122.hsd1.ca.comcast.net. [73.241.114.122]) by smtp.gmail.com with ESMTPSA id u9sm3755812pje.20.2021.02.23.08.11.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Feb 2021 08:11:39 -0800 (PST) Date: Tue, 23 Feb 2021 08:11:36 -0800 From: Richard Cochran To: Heiko Thiery Cc: Jakub Kicinski , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, "David S . Miller" , Fugang Duan Subject: Re: [PATCH 1/1] net: fec: ptp: avoid register access when ipg clock is disabled Message-ID: <20210223161136.GA5894@hoboy.vegasvil.org> References: <20210220065654.25598-1-heiko.thiery@gmail.com> <20210222190051.40fdc3e9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210223142726.GA4711@hoboy.vegasvil.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 23, 2021 at 04:04:16PM +0100, Heiko Thiery wrote: > It is not only the PHC clock that stops. Rather, it is the entire > ethernet building block in the SOC that is disabled, including the > PHC. Sure, but why does the driver do that? Thanks, Richard