Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Kees Cook <keescook@chromium.org>
To:     Anton Vorontsov <anton@enomsg.org>,
        Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
        Colin Cross <ccross@android.com>,
        Tony Luck <tony.luck@intel.com>
Cc:     Kees Cook <keescook@chromium.org>, linux-kernel@vger.kernel.org,
        syzbot <syzbot+d0cf0ad6513e9a1da5df@syzkaller.appspotmail.com>
Subject: Re: [PATCH] pstore: fix warning in pstore_kill_sb()
Date:   Tue, 23 Feb 2021 09:30:11 -0800
Message-Id: <161410140523.3588113.12183751046979550289.b4-ty@chromium.org>
In-Reply-To: <20210214031307.57903-1-penguin-kernel@I-love.SAKURA.ne.jp>
References: <00000000000084130f05bb3aa802@google.com> <20210214031307.57903-1-penguin-kernel@I-love.SAKURA.ne.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Sun, 14 Feb 2021 12:13:07 +0900, Tetsuo Handa wrote:
> syzbot is hitting WARN_ON(pstore_sb != sb) at pstore_kill_sb() [1], for the
> assumption that pstore_sb != NULL is wrong because pstore_fill_super() will
> not assign pstore_sb = sb when new_inode() for d_make_root() returned NULL
> (due to memory allocation fault injection).
> 
> Since mount_single() calls pstore_kill_sb() when pstore_fill_super()
> failed, pstore_kill_sb() needs to be aware of such failure path.
> 
> [...]

Applied to for-next/pstore, thanks!

[1/1] pstore: Fix warning in pstore_kill_sb()
      https://git.kernel.org/kees/c/9c7d83ae6ba6

-- 
Kees Cook