Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 23 Feb 2021 09:30:47 -0800
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     Michael Tretter <m.tretter@pengutronix.de>
Cc:     Geert Uytterhoeven <geert+renesas@glider.be>,
        Andrej Valek <andrej.valek@siemens.com>,
        linux-input@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: st1232 - Fix NORMAL vs. IDLE state handling
Message-ID: <YDU7x/f4ez5nuFn5@google.com>
References: <20210223090201.1430542-1-geert+renesas@glider.be>
 <20210223102900.GA8833@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210223102900.GA8833@pengutronix.de>
Precedence: bulk

On Tue, Feb 23, 2021 at 11:29:00AM +0100, Michael Tretter wrote:
> On Tue, 23 Feb 2021 10:02:01 +0100, Geert Uytterhoeven wrote:
> > NORMAL (0x0) and IDLE (0x4) are really two different states.  Hence you
> > cannot check for both using a bitmask, as that checks for IDLE only,
> > breaking operation for devices that are in NORMAL state.
> 
> Thanks. I missed that the state is actually a value and not a bitfield.
> 
> > 
> > Fix the wait function to report either state as ready.
> > 
> > Fixes: 6524d8eac258452e ("Input: st1232 - add IDLE state as ready condition")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>

Applied, thank you.

-- 
Dmitry