Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 23 Feb 2021 17:10:06 +0100
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     Md Sadre Alam <mdalam@codeaurora.org>
Cc:     mani@kernel.org, richard@nod.at, boris.brezillon@collabora.com,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
        sricharan@codeaurora.org
Subject: Re: [PATCH] mtd: rawnand: qcom: Convert nandc to chip in Read/Write
 helper
Message-ID: <20210223171006.3e2030ce@xps13>
In-Reply-To: <1613939101-23001-1-git-send-email-mdalam@codeaurora.org>
References: <1613939101-23001-1-git-send-email-mdalam@codeaurora.org>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

Hello,

Md Sadre Alam <mdalam@codeaurora.org> wrote on Mon, 22 Feb 2021
01:55:01 +0530:

> This change will convert nandc to chip in Read/Write helper, this
> change is needed because if we wnated to access number of steps
> in Read/Write helper then we need to get the chip->ecc.steps,
> currentlly its not possible.After this change we can directly
> acces chip->ecc.steps in Read/Write helper.
> 
> Signed-off-by: Md Sadre Alam <mdalam@codeaurora.org>

Thanks for splitting your series, I think it's much easier to review
and contains much less imprecise changes.

I have a few minor comments (see the following e-mails), please address
them and then please send all your patches a single series, not like 6+
independent patches.

I'll then require someone to test it if we are good I'll merge it.

Thanks,
Miquèl