Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\))
Subject: Re: [PATCH 1/2] dt-bindings: usb: generic-ehci: document ignore-oc
 flag
From:   =?utf-8?Q?=C3=81lvaro_Fern=C3=A1ndez_Rojas?= <noltari@gmail.com>
In-Reply-To: <20210223155443.GB1261797@rowland.harvard.edu>
Date:   Tue, 23 Feb 2021 17:04:57 +0100
Cc:     Florian Fainelli <f.fainelli@gmail.com>,
        Jonas Gorski <jonas.gorski@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Tony Prisk <linux@prisktech.co.nz>, linux-usb@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <54E1894F-C8D8-4E2F-92DF-DC891153BAAB@gmail.com>
References: <20210223155005.21712-1-noltari@gmail.com>
 <20210223155005.21712-2-noltari@gmail.com>
 <20210223155443.GB1261797@rowland.harvard.edu>
To:     Alan Stern <stern@rowland.harvard.edu>
Precedence: bulk

Hi Alan,

> El 23 feb 2021, a las 16:54, Alan Stern <stern@rowland.harvard.edu> =
escribi=C3=B3:
>=20
> On Tue, Feb 23, 2021 at 04:50:04PM +0100, =C3=81lvaro Fern=C3=A1ndez =
Rojas wrote:
>> Over-current reporting isn't supported on some platforms such as =
bcm63xx.
>> These devices will incorrectly report over-current if this flag isn't =
properly
>> activated.
>>=20
>> Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas <noltari@gmail.com>
>> ---
>> Documentation/devicetree/bindings/usb/generic-ehci.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>=20
>> diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml =
b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
>> index cf83f2d9afac..294bbf02399e 100644
>> --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml
>> +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml
>> @@ -117,6 +117,11 @@ properties:
>>       Set this flag if EHCI has a Transaction Translator built into
>>       the root hub.
>>=20
>> +  ignore-oc:
>> +    $ref: /schemas/types.yaml#/definitions/flag
>> +    description:
>> +      Set this flag for HCDs without over-current reporting support.
>=20
> This is not a good description of a device property.  DT entries are=20=

> supposed to described the hardware, not talk about how to use it.

Any suggestions on a proper description?

>=20
> When you say that the bcm63xx doesn't support over-current reporting,=20=

> what exactly do you mean?  Do you mean that sometimes the hardware =
turns=20
> on the over-current bit when an over-current isn't actually present?  =
Or=20
> do you mean something else?

Yes, the hardware turns on the over-current bit with no over-current =
present.

>=20
> Alan Stern
>=20
>> +
>>   needs-reset-on-resume:
>>     $ref: /schemas/types.yaml#/definitions/flag
>>     description:
>> --=20
>> 2.20.1

Best regards,
=C3=81lvaro.