Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2678123pxb; Tue, 23 Feb 2021 12:46:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJwGc8NsOlK6d1DyHkDvScB6Ar54z7DX909vxxET73jFtOPuO6K+jBOAdUED2yhm5vyK/fo/ X-Received: by 2002:aa7:ca59:: with SMTP id j25mr20470151edt.175.1614113197258; Tue, 23 Feb 2021 12:46:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614113197; cv=none; d=google.com; s=arc-20160816; b=MgwwdBYNlmDRkUwm+aeyzSqGzH3M7RyhOYiHx0wCXnv6C97TAmXAw3M9mD4NZF7EFR 6VvY/VO7BIrxLGWiUo95iW2lKkdAqWK20nHXqRgnFe30sWFxa+gPotC2vt2O+9YOcvXx iB9O3CKpebXieuSO4mrcq8AeyiJKcWscG/zdXQM8SOViK2cntcVmqF7i/171rQZqlsui iCjRC5UBFuVnTEBs/OVXqIY57OKEemah7tQkhNTI+gs0XGJZY3Dtrv3NRyz6fYTHJ8fl PH26jzOXu3XKzAQcyX6rxCXKFKWkuT46eeHQHO02NcHjXSed9hAeEyR+3elTmSEvMWQ5 +g6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=hzu6oyq2vzKtdaxBT11x7kT56EgUWUudoeqFZkEseBk=; b=XHClXQutkgBTLi42VtSBn/VFwa52l41HhWnKCY0Zbd450ULQtQAQKGk7UkhZItu8Ag A/xLKneXpazATjxrGd6/cbzR61godwr47n/ZOhfIjIB0UGhpU7QJ1JvXhBFb+g7tggAq RjA9w75eHk5Bac9HQ0LpWrYeAQabtqVyBz7yl5/uaKqibcs6smdL+q1SXQdMYdGSR+9X 71QeoJ5eKUX1TI6D9oH8zp//mHE8Wa9xnQ5keeDiSbx+0H8Jn99KZmJ73ZfSF9U7xSjX UfZtgkZkU5Q/gQ8V537flxctz8QOl4cU1dsFHFVz/R4RPnEZIL3QDADimj7OMxMEHcFS WbLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v22si14959122edt.571.2021.02.23.12.46.08; Tue, 23 Feb 2021 12:46:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233545AbhBWTPM (ORCPT + 99 others); Tue, 23 Feb 2021 14:15:12 -0500 Received: from mga12.intel.com ([192.55.52.136]:41871 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231878AbhBWTPF (ORCPT ); Tue, 23 Feb 2021 14:15:05 -0500 IronPort-SDR: e1/j+ZqYngGZz4YUFQqbLqzxHrvH4R6fOXPz0aYY88KVVBKvEgeIOHhr7uNyL2/xycklLaE9z7 ogp4XY4VZGNg== X-IronPort-AV: E=McAfee;i="6000,8403,9904"; a="164142010" X-IronPort-AV: E=Sophos;i="5.81,200,1610438400"; d="scan'208";a="164142010" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2021 11:14:15 -0800 IronPort-SDR: n5n5+j4Z4lIS9yhmxAoeSE1Lb8xQvIE9wSG5TbU2c36rcfYsvNSa79Fgvur5KH7I9UVy2IZYO8 DuEWLDuuBytQ== X-IronPort-AV: E=Sophos;i="5.81,200,1610438400"; d="scan'208";a="431060530" Received: from bdchartr-mobl3.amr.corp.intel.com (HELO [10.209.183.77]) ([10.209.183.77]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2021 11:14:14 -0800 Subject: Re: [PATCH] x86/sgx: Add a basic NUMA allocation scheme to sgx_alloc_epc_page() To: Jarkko Sakkinen , linux-sgx@vger.kernel.org Cc: haitao.huang@intel.com, dan.j.williams@intel.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dave Hansen , linux-kernel@vger.kernel.org References: <20210221020631.171404-1-jarkko@kernel.org> <7acc3c1c-373e-cfee-e838-2af170e87d98@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <3b3391bc-8c40-cf08-d09d-90ff1517ff8c@intel.com> Date: Tue, 23 Feb 2021 11:14:10 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <7acc3c1c-373e-cfee-e838-2af170e87d98@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/21/21 4:54 PM, Dave Hansen wrote: > Instead of having a for-each-section loop, I'd make it for-each-node -> > for-each-section. Something like: > > for (i = 0; i < num_possible_nodes(); i++) { > node = (numa_node_id() + i) % num_possible_nodes() > > if (!node_isset(nid, sgx_numa_mask)) > continue; > > list_for_each_entry(section, &sgx_numa_nodes[nid], > section_list) { > __sgx_alloc_epc_page_from_section(section) > } > } OK, here's an almost completely fleshed-out loop: page = NULL; node = numa_node_id(); start_node = node; while (1) { list_for_each_entry(section, &sgx_numa_nodes[nid], section_list) { page = __sgx_alloc_epc(section); if (page) break; } if (page) break; /* * EPC allocation failed on 'node'. Fall * back with round-robin to other nodes with * EPC: */ node = next_node_in(node, sgx_numa_mask); /* Give up if allocation wraps back to the start: */ if (node == start_node) break; } This will: 1. Always start close to the CPU that started the allocation 2. Always spread the allocations out among nodes evenly, never concentrating allocations on node 0, for instance. (This could also be node_random() and get a similar effect, but this probably has slightly better default NUMA behavior). 3. Efficiently look among all nodes because of 'sgx_numa_mask' 4. Have no special case for the first allocation. All allocations will be satisfied from this unified loop. 5. Compile down to no loop on CONFIG_NUMA=y systems. 6. Be guaranteed to make forward progress even if preempted and numa_node_id() changes in the loop. BTW, I think the name of __sgx_alloc_epc_page_from_section() can be shortened down. It's passed a section and returns a page, so both of those could be removed from the name.