Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        "Daniel Borkmann" <daniel@iogearbox.net>,
        Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v4 bpf-next 2/6] bpf: prevent deadlock from recursive
 bpf_task_storage_[get|delete]
Thread-Topic: [PATCH v4 bpf-next 2/6] bpf: prevent deadlock from recursive
 bpf_task_storage_[get|delete]
Thread-Index: AQHXCYIynt1KuoobvEWNWRDMRSL2HapllNIAgACi7QA=
Date:   Tue, 23 Feb 2021 20:49:32 +0000
Message-ID: <A6645DA7-41B1-431E-8C5F-1CDAC1445242@fb.com>
References: <20210223012014.2087583-1-songliubraving@fb.com>
 <20210223012014.2087583-3-songliubraving@fb.com>
 <YDThrlixVqfHP7I9@hirez.programming.kicks-ass.net>
In-Reply-To: <YDThrlixVqfHP7I9@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B7FF4B6A2D30E54D9685D7931B363B0C@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bd29080-ad42-4812-5ef9-08d8d83c8584
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2021 20:49:32.1038
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: D9HBFmV8p8zCOzGRiZKDIRM7/xiYMo4bI5kA0vzris2CigMGJoIoWlCzVh3IZws4y82QCk2ikxPAi4wUOdu5dw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR15MB2849
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761
 definitions=2021-02-23_08:2021-02-23,2021-02-23 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 lowpriorityscore=0
 phishscore=0 spamscore=0 clxscore=1015 adultscore=0 priorityscore=1501
 impostorscore=0 bulkscore=0 malwarescore=0 mlxscore=0 mlxlogscore=971
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2102230176
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Feb 23, 2021, at 3:06 AM, Peter Zijlstra <peterz@infradead.org> wrote:
>=20
> On Mon, Feb 22, 2021 at 05:20:10PM -0800, Song Liu wrote:
>> BPF helpers bpf_task_storage_[get|delete] could hold two locks:
>> bpf_local_storage_map_bucket->lock and bpf_local_storage->lock. Calling
>> these helpers from fentry/fexit programs on functions in bpf_*_storage.c
>> may cause deadlock on either locks.
>>=20
>> Prevent such deadlock with a per cpu counter, bpf_task_storage_busy, whi=
ch
>> is similar to bpf_prog_active. We need this counter to be global, becaus=
e
>=20
> So bpf_prog_active is one of the biggest turds around, and now you're
> making it worse ?!

bpf_prog_active is a distraction here. We are trying to enable task local=20
storage for fentry/fext programs, which do not use bpf_prog_active.

bpf_task_storage_busy counter is introduced to protect against a specific=20
pattern of deadlocks (attaching fentry/fexit on bpf_task_storage_[get|delet=
e]=20
helpers, then let the programs call these two helpers again).=20

Thanks,
Song=