Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <c7fd9642-7dcb-42bc-18e9-6fd86d8f5be8@codeaurora.org>
References: <20210223214539.1336155-1-swboyd@chromium.org> <20210223214539.1336155-4-swboyd@chromium.org> <c7fd9642-7dcb-42bc-18e9-6fd86d8f5be8@codeaurora.org>
Subject: Re: [PATCH 3/6] firmware: qcom_scm: Workaround lack of "is available" call on SC7180
From:   Stephen Boyd <swboyd@chromium.org>
Cc:     linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        Elliot Berman <eberman@codeaurora.org>,
        Brian Masney <masneyb@onstation.org>,
        Stephan Gerhold <stephan@gerhold.net>,
        Douglas Anderson <dianders@chromium.org>
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Jeffrey Hugo <jhugo@codeaurora.org>
Date:   Tue, 23 Feb 2021 15:46:30 -0800
Message-ID: <161412399088.1254594.11162340495979939098@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Jeffrey Hugo (2021-02-23 15:38:38)
> On 2/23/2021 2:45 PM, Stephen Boyd wrote:
> > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> > index 21e07a464bd9..9ac84b5d6ce0 100644
> > --- a/drivers/firmware/qcom_scm.c
> > +++ b/drivers/firmware/qcom_scm.c
> > @@ -144,6 +145,18 @@ static enum qcom_scm_convention __get_convention(v=
oid)
> >       if (!ret && res.result[0] =3D=3D 1)
> >               goto found;
> >  =20
> > +     /*
> > +      * Some SC7180 firmwares didn't implement the
> > +      * QCOM_SCM_INFO_IS_CALL_AVAIL call, so we fallback to forcing AR=
M_64
> > +      * calling conventions on these firmwares. Luckily we don't make =
any
> > +      * early calls into the firmware on these SoCs so the device poin=
ter
> > +      * will be valid here to check if the compatible matches.
> > +      */
> > +     if (of_device_is_compatible(__scm ? __scm->dev->of_node : NULL, "=
qcom,scm-sc7180")) {
> > +             forced =3D true;
> > +             goto found;
> > +     }
>=20
> All SC7180 targets run DT?  None have ACPI?
>=20

Yes, as far as I know all sc7180 boards are using DT. If they aren't,
then presumably they implemented this QCOM_SCM_INFO_IS_CALL_AVAIL call
so this check is still fine.