Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp34255pxb; Tue, 23 Feb 2021 17:10:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJx6Bqph7TbA0LBOSeH34cZlFRPy7/iUCt92Iyt7kVxm31tfk+LOE2tAtrVuwEc1zO7jxqHS X-Received: by 2002:a05:6402:5194:: with SMTP id q20mr8897877edd.267.1614129026334; Tue, 23 Feb 2021 17:10:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614129026; cv=none; d=google.com; s=arc-20160816; b=hKRasT6SznLaGrRFZSfXEeuhNHU67i8Dz6pl3fYz2NJZGvo2EmiqA0/159BUwKA+7P 77IUZ2bzpR8F7aJP8ijhhVKj6HJxgWvAJZxN7qoasX0gaE/N1Jeol9pM0GFerk6S+fCa adN0Rx2OOG1VJBTOHUQyHNSXgu1C9JYc+UjiEKB26W2Lhc5CtK4eRKzKxi/eqQ6WZwqP It1dalaKlUKnSv+S93xRqL+JqSXBs/Wf7PJvwMGTP1OQH665Z5T/KixnvhbqGWJK8ABC ynqob9h6heZ30RWhhgTk47ibGWuI97nzcuvphF1vX1zsVjBv7RsZ9f+s7Y09pA1i9ceo 19Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=lPncpiKvg9uNcvMDncpoj8xjAXBopfhAowBi87SRRpQ=; b=E/kKkkMcRZxl5iLmWplwZ+Zz6nVVL+c7Zvhll/pbN4UuAdysQh00Pm0Pu0zgBvqsfT 74E6I96Q/W3ecuWLF4U7hGCjcasCDtfU0p81igaSu5SXxIR0D6rWt7XoEm8IhDNuN+H8 xXlir6mFcaCIFSxxzoKLUnOzC0F2H+gW1K/6xC+JCV191bD6AGc5VopAHsrtQSGRFOMu YJ1zspvLn5xz1UzE0ccdm1JLbOEnrnSZkdTKaNZ7Gb0S8fw1kQPFmszLxmYX/VHQf4xt NIfZpjNxA9sM7fOTIeu0LxxVKy+wrdvnqD6NwbUVgNt2NJ50myRVqcx1GosV7xfKuMQ+ SFfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=J8gXSgvo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f16si120430edy.263.2021.02.23.17.09.51; Tue, 23 Feb 2021 17:10:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=J8gXSgvo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232649AbhBXAtV (ORCPT + 99 others); Tue, 23 Feb 2021 19:49:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:57290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234652AbhBXAEj (ORCPT ); Tue, 23 Feb 2021 19:04:39 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8939B64EC3; Tue, 23 Feb 2021 23:59:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1614124746; bh=jd3AHbAwpBRRufGrU+vgpTbPZS/a3wHGQ7fEjIZmmO0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=J8gXSgvocsbDOdNuw2uM/tZVsiBnjNhvfF6J9y5QDoWBYSR9ANJRaWOuau92QJ4IH JDvz9mABEnSiDCPTBlX5g+rnonB3Pl8h/O6++VqjP/vatfuYBOdLJglqCebnbFvvm4 GVyizs6325/7QuASONKyBfr7KHNl46CDUl+MGGgM= Date: Tue, 23 Feb 2021 15:59:05 -0800 From: Andrew Morton To: Johannes Berg Cc: Jan Kiszka , linux-kernel@vger.kernel.org, Kieran Bingham Subject: Re: [PATCH v2] gdb: lx-symbols: store the abspath() Message-Id: <20210223155905.ef395fd41affb2a49daf9bbd@linux-foundation.org> In-Reply-To: <21aa1d80eccede559bebf7201f03a74e67272b4f.camel@sipsolutions.net> References: <20201217091747.bf4332cf2b35.I10ebbdb7e9b80ab1a5cddebf53d073be8232d656@changeid> <60d43738-1d89-30b0-54bd-8303daeadc57@siemens.com> <21aa1d80eccede559bebf7201f03a74e67272b4f.camel@sipsolutions.net> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Feb 2021 16:12:17 +0100 Johannes Berg wrote: > On Thu, 2020-12-17 at 09:31 +0100, Jan Kiszka wrote: > > On 17.12.20 09:17, Johannes Berg wrote: > > > From: Johannes Berg > > > > > > If we store the relative path, the user might later cd to a > > > different directory, and that would break the automatic symbol > > > resolving that happens when a module is loaded into the target > > > kernel. Fix this by storing the abspath() of each path given, > > > just like we already do for the cwd (os.getcwd() is absolute.) > > > Reviewed-by: Jan Kiszka > > So ... I'm still carrying this patch. > > Anyone want to send it to Linus? Andrew, maybe you? Sure, I'll grab it after -rc1.