Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 23 Feb 2021 16:40:26 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     netdev@vger.kernel.org, Denis Kirjanov <kda@linux-powerpc.org>,
        Christoph Hellwig <hch@infradead.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [PATCHSET] making unix_bind() undo mknod on failure
Message-ID: <20210223164026.01b56449@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <YDQAmH9zSsaqf+Dg@zeniv-ca.linux.org.uk>
References: <20210129131855.GA2346744@infradead.org>
        <YClpVIfHYyzd6EWu@zeniv-ca.linux.org.uk>
        <CAOJe8K00srtuD+VAJOFcFepOqgNUm0mC8C=hLq2=qhUFSfhpuw@mail.gmail.com>
        <YCwIQmsxWxuw+dnt@zeniv-ca.linux.org.uk>
        <YC86WeSTkYZqRlJY@zeniv-ca.linux.org.uk>
        <YC88acS6dN6cU1y0@zeniv-ca.linux.org.uk>
        <CAM_iQpVpJwRNKjKo3p1jFvCjYAXAY83ux09rd2Mt0hKmvx=RgQ@mail.gmail.com>
        <YDFj3OZ4DMQSqylH@zeniv-ca.linux.org.uk>
        <CAM_iQpXX7SBGgUkBUY6BEjCqJYbHAUW5Z3VtV2U=yhiw1YJr=w@mail.gmail.com>
        <YDF6Z8QHh3yw7es9@zeniv-ca.linux.org.uk>
        <YDQAmH9zSsaqf+Dg@zeniv-ca.linux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 22 Feb 2021 19:06:00 +0000 Al Viro wrote:
> On Sat, Feb 20, 2021 at 09:08:56PM +0000, Al Viro wrote:
> 
> > *shrug*
> > 
> > If anything, __unix_complete_bind() might make a better name for that,
> > with dropping ->bindlock also pulled in, but TBH I don't have sufficiently
> > strong preferences - might as well leave dropping the lock to caller.
> > 
> > I'll post that series to netdev tonight.  
> 
> 	Took longer than I hoped...  Anyway, here's the current variant;
> it's 5.11-based, lives in
> git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git misc.af_unix
> 
> Shortlog:
> Al Viro (8):
>       af_unix: take address assignment/hash insertion into a new helper
>       unix_bind(): allocate addr earlier
>       unix_bind(): separate BSD and abstract cases
>       unix_bind(): take BSD and abstract address cases into new helpers
>       fold unix_mknod() into unix_bind_bsd()
>       unix_bind_bsd(): move done_path_create() call after dealing with ->bindlock
>       unix_bind_bsd(): unlink if we fail after successful mknod
>       __unix_find_socket_byname(): don't pass hash and type separately
> 
> Diffstat:
>  net/unix/af_unix.c | 186 +++++++++++++++++++++++++++--------------------------
>  1 file changed, 94 insertions(+), 92 deletions(-)
> 
> The actual fix is in #7/8, the first 6 are massage in preparation to that
> and #8/8 is a minor followup cleanup.  Individual patches in followups.

Dave is out this week, but this looks good to me. You said "please
review" - I'm assuming you'll send these to Linus yourself, so:

Acked-by: Jakub Kicinski <kuba@kernel.org>