Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210223181425.4010665-1-robh@kernel.org> <20210223181425.4010665-2-robh@kernel.org>
 <CAK7LNAQYfMGTUehk4-=UGcT4Tc66fZ67vbJKr36YDpxB52mDJQ@mail.gmail.com>
In-Reply-To: <CAK7LNAQYfMGTUehk4-=UGcT4Tc66fZ67vbJKr36YDpxB52mDJQ@mail.gmail.com>
From:   Rob Herring <robh@kernel.org>
Date:   Tue, 23 Feb 2021 19:12:44 -0600
Message-ID: <CAL_Jsq+4a3KrZpQ-RoN2+RU2iwNGj6aEipfegC4dFW6RyiT2cw@mail.gmail.com>
Subject: Re: [PATCH 1/3] kbuild: Make old-atomics and missing-syscalls phony targets
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Michal Marek <michal.lkml@markovi.net>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        X86 ML <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 23, 2021 at 6:47 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Wed, Feb 24, 2021 at 3:14 AM Rob Herring <robh@kernel.org> wrote:
> >
> > The old-atomics and missing-syscalls targets are not files, so they
> > should be marked as PHONY.
> >
> > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > Cc: Michal Marek <michal.lkml@markovi.net>
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> >  Kbuild | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Kbuild b/Kbuild
> > index fa441b98c9f6..032157c3ffd2 100644
> > --- a/Kbuild
> > +++ b/Kbuild
> > @@ -44,6 +44,7 @@ always-y += missing-syscalls
> >  quiet_cmd_syscalls = CALL    $<
> >        cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags) $(missing_syscalls_flags)
> >
> > +PHONY += missing-syscalls
> >  missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE
> >         $(call cmd,syscalls)
> >
> > @@ -55,5 +56,6 @@ always-y += old-atomics
> >  quiet_cmd_atomics = CALL    $<
> >        cmd_atomics = $(CONFIG_SHELL) $<
> >
> > +PHONY += old-atomics
>
>
> I do not think this is the right fix.
>
> always-y (specified a few lines above) adds $(obj)/ prefix,
> and is not supposed to work with PHONY.
>
>
> It is wrong to blindly eliminate
> the errors detected by your 3/3

What about checking just hostprogs and userprogs? That's what I
initially had, but thought we could widen the net a little.

Rob